You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/14 17:03:44 UTC
[Impala-ASF-CR] IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6388
Change subject: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
......................................................................
IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Remove some UDF-related URLs pointing to /cloudera/ github
from the XML source.
The HTML links still point to /cloudera/ URLs, but those can
be re-pointed easily without touching this same source file.
Also change some /user/cloudera/ references to an HDFS
user name.
Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
---
M docs/topics/impala_udf.xml
1 file changed, 15 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/6388/1
--
To view, visit http://gerrit.cloudera.org:8080/6388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/94/
--
To view, visit http://gerrit.cloudera.org:8080/6388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6388/1/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:
PS1, Line 235: For example, the path might be
: like <filepath>/usr/lib/hive/lib/hive-exec-0.10.0-cdh4.2.0.jar</filepath>, with different version
: numbers corresponding to your specific level of CDH.
CDH filepath and CDH ref and the end of the line.
--
To view, visit http://gerrit.cloudera.org:8080/6388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
......................................................................
Patch Set 2: Code-Review+1
looks good now.
--
To view, visit http://gerrit.cloudera.org:8080/6388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
......................................................................
IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Remove some UDF-related URLs pointing to /cloudera/ github
from the XML source.
The HTML links still point to /cloudera/ URLs, but those can
be re-pointed easily without touching this same source file.
Also change some /user/cloudera/ references to an HDFS
user name.
Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
---
M docs/topics/impala_udf.xml
1 file changed, 17 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/6388/2
--
To view, visit http://gerrit.cloudera.org:8080/6388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
......................................................................
IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Remove some UDF-related URLs pointing to /cloudera/ github
from the XML source.
The HTML links still point to /cloudera/ URLs, but those can
be re-pointed easily without touching this same source file.
Also change some /user/cloudera/ references to an HDFS
user name.
Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Reviewed-on: http://gerrit.cloudera.org:8080/6388
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_udf.xml
1 file changed, 17 insertions(+), 21 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Ambreen Kazi: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Turn UDF github links into keyrefs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1aec8b2dbe1316c98a40f05ad537b8f173208d6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No