You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ja...@apache.org on 2018/11/06 12:24:39 UTC
carbondata git commit: [CARBONDATA-3067] Add check for debug to avoid
string concat
Repository: carbondata
Updated Branches:
refs/heads/master b6ff4672b -> 35fb9409d
[CARBONDATA-3067] Add check for debug to avoid string concat
For bloomfilter datamap, it will log debug for each blocklet. If the
data is huge, there maybe thousands of blocklet, so in this commit, we
will try to avoid necessary string concat if the debug level is not
enabled.
This closes #2889
Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/35fb9409
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/35fb9409
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/35fb9409
Branch: refs/heads/master
Commit: 35fb9409d453c006d640e5e77938b91b6b7ae966
Parents: b6ff467
Author: xuchuanyin <xu...@hust.edu.cn>
Authored: Thu Nov 1 10:09:40 2018 +0800
Committer: Jacky Li <ja...@qq.com>
Committed: Tue Nov 6 20:24:22 2018 +0800
----------------------------------------------------------------------
.../datamap/bloom/BloomCoarseGrainDataMap.java | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/carbondata/blob/35fb9409/datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
----------------------------------------------------------------------
diff --git a/datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java b/datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
index 4ec215e..7a104fc 100644
--- a/datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
+++ b/datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
@@ -185,7 +185,9 @@ public class BloomCoarseGrainDataMap extends CoarseGrainDataMap {
}
for (BloomQueryModel bloomQueryModel : bloomQueryModels) {
Set<Blocklet> tempHitBlockletsResult = new HashSet<>();
- LOGGER.debug("prune blocklet for query: " + bloomQueryModel);
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("prune blocklet for query: " + bloomQueryModel);
+ }
BloomCacheKeyValue.CacheKey cacheKey = new BloomCacheKeyValue.CacheKey(
this.indexPath.toString(), bloomQueryModel.columnName);
BloomCacheKeyValue.CacheValue cacheValue = cache.get(cacheKey);
@@ -205,12 +207,14 @@ public class BloomCoarseGrainDataMap extends CoarseGrainDataMap {
}
}
if (scanRequired) {
- LOGGER.debug(String.format("BloomCoarseGrainDataMap: Need to scan -> blocklet#%s",
- String.valueOf(bloomFilter.getBlockletNo())));
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug(String.format("BloomCoarseGrainDataMap: Need to scan -> blocklet#%s",
+ String.valueOf(bloomFilter.getBlockletNo())));
+ }
Blocklet blocklet = new Blocklet(bloomFilter.getShardName(),
String.valueOf(bloomFilter.getBlockletNo()));
tempHitBlockletsResult.add(blocklet);
- } else {
+ } else if (LOGGER.isDebugEnabled()) {
LOGGER.debug(String.format("BloomCoarseGrainDataMap: Skip scan -> blocklet#%s",
String.valueOf(bloomFilter.getBlockletNo())));
}