You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2022/11/16 06:42:38 UTC

[skywalking] branch banyandb updated (21abc42db8 -> b196e77793)

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a change to branch banyandb
in repository https://gitbox.apache.org/repos/asf/skywalking.git


 discard 21abc42db8 Ignore "ui_template" on checking whether a table exists
     new b196e77793 Ignore "ui_template" on checking whether a table exists

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (21abc42db8)
            \
             N -- N -- N   refs/heads/banyandb (b196e77793)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 docs/en/changes/changes.md | 1 +
 1 file changed, 1 insertion(+)


[skywalking] 01/01: Ignore "ui_template" on checking whether a table exists

Posted by ha...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch banyandb
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit b196e7779394a9b85a99bf1e07f8061cc897f5fd
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Wed Nov 16 06:37:06 2022 +0000

    Ignore "ui_template" on checking whether a table exists
    
    Signed-off-by: Gao Hongtao <ha...@gmail.com>
---
 docs/en/changes/changes.md                                             | 1 +
 .../oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java     | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 008b3feb94..c9f1292208 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -110,6 +110,7 @@
 * Bump up Kafka client to 2.8.1 to fix CVE-2021-38153.
 * Remove `lengthEnvVariable` for `Column` as it never works as expected.
 * Add `LongText` to support longer logs persistent as a text type in ElasticSearch, instead of a keyword, to avoid length limitation.
+* Ignore "ui_template" on checking whether a table exists in the BanyanDB installation process.
 
 #### UI
 
diff --git a/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java b/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java
index 7a16eab863..c4289743ee 100644
--- a/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java
+++ b/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java
@@ -44,6 +44,9 @@ public class BanyanDBIndexInstaller extends ModelInstaller {
 
     @Override
     public boolean isExists(Model model) throws StorageException {
+        if (!model.isTimeSeries()) { // UITemplate
+            return true;
+        }
         final ConfigService configService = moduleManager.find(CoreModule.NAME).provider().getService(ConfigService.class);
         final MetadataRegistry.SchemaMetadata metadata = MetadataRegistry.INSTANCE.parseMetadata(model, config, configService);
         try {