You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/04/01 09:53:38 UTC
[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2211
[ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of interpreter type pkg
### What is this PR for?
Currently "see more" is placed next to the older version of INTERPRETER type of Helium pkg. But other type of Helium pkg(e.g. SPELL or VISUALIZATION) has "enable". And if we click "enable", can see the dialog for asking if you want to enable the package or not. So I changed INTERPRETER type pkg's "see more" to "enable" for the consistency in this patch.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2339](https://issues.apache.org/jira/browse/ZEPPELIN-2339)
### How should this be tested?
1. Run Zeppelin web under `zeppelin-web` with
```
$ yarn run dev
```
2. Go to Helium menu and click any interpreter type of package
3. Click `versions`
4. there should be "enable" not "see more"
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2211
----
commit 64597eca559b0a2a7b470e2525ea1311e53c47d5
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-04-01T09:47:42Z
Change 'see more' -> 'enable' next to the older ver of intp type pkg
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' next to ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2211
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2211
[ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of interpreter type pkg
### What is this PR for?
Currently "see more" is placed next to the older version of INTERPRETER type of Helium pkg. But other type of Helium pkg(e.g. SPELL or VISUALIZATION) has "enable". And if we click "enable", can see the dialog for asking if you want to enable the package or not. So I changed INTERPRETER type pkg's "see more" to "enable" for the consistency in this patch.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2339](https://issues.apache.org/jira/browse/ZEPPELIN-2339)
### How should this be tested?
1. Run Zeppelin web under `zeppelin-web` with
```
$ yarn run dev
```
2. Go to Helium menu and click any interpreter type of package
3. Click `versions`
4. there should be "enable" not "see more"
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2211
----
commit 64597eca559b0a2a7b470e2525ea1311e53c47d5
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-04-01T09:47:42Z
Change 'see more' -> 'enable' next to the older ver of intp type pkg
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' next to ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2211
@felixcheung @Leemoonsoo Thanks.
Merge into master if there are no further comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---