[GitHub] [airflow] anitakar commented on a change in pull request #7296: [AIRFLOW-XXXX] Make REST API respect STORE_SERIALIZED_DAG setting

[GitBox <gi...@apache.org>]

anitakar commented on a change in pull request #7296: [AIRFLOW-XXXX] Make REST API respect STORE_SERIALIZED_DAG setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r372933497
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   This probably point to the fact that i should have written a test or e2e test this case but what will happen if core.store_serialized_dags is not specified KeyError or will it coerce to false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services