You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Antoine Toulme (JIRA)" <ji...@apache.org> on 2010/07/10 19:38:50 UTC

[jira] Commented: (BUILDR-468) test:failed does not respect test.exclude

    [ https://issues.apache.org/jira/browse/BUILDR-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887074#action_12887074 ] 

Antoine Toulme commented on BUILDR-468:
---------------------------------------

Shane, I don't reproduce the problem ? I committed a spec with this commit:

10:37:00~/w/buildr>svn ci spec/core/test_spec.rb -m "spec for BUILDR-468"
Sending        spec/core/test_spec.rb
Transmitting file data .
Committed revision 962892.

10:36:54~/w/buildr>di spec/core/test_spec.rb
Index: spec/core/test_spec.rb
===================================================================
--- spec/core/test_spec.rb	(revision 961875)
+++ spec/core/test_spec.rb	(working copy)
@@ -945,6 +945,20 @@
     project('foo').test.tests.should include('FailingTest')
     project('foo').test.tests.should_not include('PassingTest')
   end
+  
+  it 'should run failed tests, respecting excluded tests' do
+    define 'foo' do
+      test.using(:junit).exclude('ExcludedTest')
+      test.instance_eval do
+        @framework.stub!(:tests).and_return(['FailingTest', 'ExcludedTest'])
+        @framework.stub!(:run).and_return([])
+      end
+    end
+    write project('foo').path_to(:target, "junit-failed"), "FailingTest\nExcludedTest"
+    task('test:failed').invoke rescue nil
+    project('foo').test.tests.should include('FailingTest')
+    project('foo').test.tests.should_not include('ExcludedTest')
+  end
 
 end

> test:failed does not respect test.exclude
> -----------------------------------------
>
>                 Key: BUILDR-468
>                 URL: https://issues.apache.org/jira/browse/BUILDR-468
>             Project: Buildr
>          Issue Type: Bug
>          Components: Test frameworks
>    Affects Versions: 1.4.1
>         Environment: JRuby 1.5.1, Windows XP
>            Reporter: Shane Witbeck
>            Assignee: Antoine Toulme
>             Fix For: 1.4.2
>
>
> I ran test:failed which resulted in an excluded test in a dependent project to run.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.