You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2021/02/28 02:57:00 UTC
[jira] [Comment Edited] (CALCITE-4514) [CALCITE-4514] Fine tune the
merge order of two RelSets
[ https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292271#comment-17292271 ]
Julian Hyde edited comment on CALCITE-4514 at 2/28/21, 2:56 AM:
----------------------------------------------------------------
I've reworked your original commit [e72bee|https://github.com/apache/calcite/commit/e72bee2c1f5a04913d86c465ac6aab7cc4cc772f], caching in local variables, clarifying control flow. See [julianhyde/4514-merge-set|https://github.com/julianhyde/calcite/tree/4514-merge-set].
Let me know whether it looks OK. I can combine with the test you added in the other commit.
was (Author: julianhyde):
I'll take a stab at reworking your original commit [e72bee|https://github.com/apache/calcite/commit/e72bee2c1f5a04913d86c465ac6aab7cc4cc772f], caching in local variables, clarifying control flow.
> [CALCITE-4514] Fine tune the merge order of two RelSets
> -------------------------------------------------------
>
> Key: CALCITE-4514
> URL: https://issues.apache.org/jira/browse/CALCITE-4514
> Project: Calcite
> Issue Type: Improvement
> Reporter: Botong Huang
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When merging two relsets, we have two preferences:
> 1. Merge parent relset into child relset
> 2. Merge newer relset into older relset
> Currently, when the two relsets are parent set of each other, we randomly pick a merge order without checking the second condition above. For performance reasons, we should, to avoid unnecessary churn.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)