You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by cvlchinet <gi...@git.apache.org> on 2014/10/12 01:03:42 UTC

[GitHub] thrift pull request: Wrap errors in iostream_transport.go

GitHub user cvlchinet opened a pull request:

    https://github.com/apache/thrift/pull/246

    Wrap errors in iostream_transport.go

    When I used the StreamTransport to do unit tests I noticed that the EOF TTransportException is not correctly thrown. I quickly found out that the errors in iostream_transport.go where not wrapped with
    NewTTransportExceptionFromError. Fixed that quickly and it works greatly!
    
    Hope this saves others precious time when developing with thrift and go :-)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cvlchinet/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit c00fa154faa337db47a07c2c49d13d51c487d77a
Author: cvlchinet <cv...@chinet.info>
Date:   2014-10-11T22:57:23Z

    Wrap errors in iostream_transport.go
    
    Wrap errors in iostream_transport.go using NewTTransportExceptionFromError

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Wrap errors in iostream_transport.go

Posted by cvlchinet <gi...@git.apache.org>.

Github user cvlchinet commented on the pull request:

    https://github.com/apache/thrift/pull/246#issuecomment-58768209
  
    The precommit seems to fail with node related stuff. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Wrap errors in iostream_transport.go

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/246


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Wrap errors in iostream_transport.go

Posted by Jens-G <gi...@git.apache.org>.

Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/246#issuecomment-58942808
  
    tracked in THRIFT-2785


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---