[GitHub] [hive] jsoref commented on a change in pull request #1674: [WIP] HIVE-24390 Spelling

[GitBox <gi...@apache.org>]

jsoref commented on a change in pull request #1674:
URL: https://github.com/apache/hive/pull/1674#discussion_r750243146



##########
File path: service/lib/php/ext/thrift_protocol/php_thrift_protocol.cpp
##########
@@ -429,7 +429,7 @@ void binary_deserialize(int8_t thrift_typeID, PHPInputTransport& transport, zval
         throw_tprotocolexception(errbuf, INVALID_DATA);
         RETURN_NULL();
       }
-      binary_deserialize_spec(return_value, transport, Z_ARRVAL_P(spec));
+      binary_deserialize_spec(return_value, transport, Z_ARRIVAL_P(spec));

Review comment:
       oops, thanks, this is just a botch ARRVAL is presumably short for array-val. dropping it and rebasing ...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org