You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2023/02/21 10:22:41 UTC

[GitHub] [logging-log4j2] ppkarwasz opened a new issue, #1281: Fix locale-dependent `toLowerCase()/toUpperCase()` calls

ppkarwasz opened a new issue, #1281:
URL: https://github.com/apache/logging-log4j2/issues/1281

   Log4j2 has a couple of remaining call sites of `String#toLowerCase()` and `String#toUpperCase()`, which are locale-dependent. These calls should be replaced with `toLowerCase(Locale.ENGLISH)` and `toUpperCase(Locale.ENGLISH)`.
   
   Such a call is present for example in `PluginManager`, which causes `IfLastModified` to be transformed to `ıflastmodified` (with a dotless i), if the locale is Turkish (cf. [this SO question](https://stackoverflow.com/q/51538312/11748454)).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Fix locale-dependent `toLowerCase()/toUpperCase()` calls (logging-log4j2)

Posted by "akashshirale14 (via GitHub)" <gi...@apache.org>.
akashshirale14 commented on issue #1281:
URL: https://github.com/apache/logging-log4j2/issues/1281#issuecomment-1549466270

   Hi Ammar,
                    Yes, you can take it.
   
   Regards,
   Akash Shirale
   
   
   
   On Tue, May 16, 2023 at 2:08 AM Ammar Yasser ***@***.***>
   wrote:
   
   > Hello, @akashshirale14 <https://github.com/akashshirale14>
   > Are you still working on this issue?, I'm interested to work on it.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/logging-log4j2/issues/1281#issuecomment-1548541020>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ALB5P4ALUFBNWHEOPGOXHGDXGKH4FANCNFSM6AAAAAAVC3LA6U>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Fix locale-dependent `toLowerCase()/toUpperCase()` calls (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz closed issue #1281: Fix locale-dependent `toLowerCase()/toUpperCase()` calls
URL: https://github.com/apache/logging-log4j2/issues/1281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Fix locale-dependent `toLowerCase()/toUpperCase()` calls (logging-log4j2)

Posted by "AmmarYasser97 (via GitHub)" <gi...@apache.org>.
AmmarYasser97 commented on issue #1281:
URL: https://github.com/apache/logging-log4j2/issues/1281#issuecomment-1548541020

   Hello, @akashshirale14 
   Are you still working on this issue?, I'm interested to work on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [logging-log4j2] ppkarwasz commented on issue #1281: Fix locale-dependent `toLowerCase()/toUpperCase()` calls

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #1281:
URL: https://github.com/apache/logging-log4j2/issues/1281#issuecomment-1438874019

   I think this can be a good first issue: there are already helper methods [`Strings#toRootLowerCase`](https://logging.apache.org/log4j/2.x/javadoc/log4j-api/org/apache/logging/log4j/util/Strings.html#toRootLowerCase-java.lang.String-) and [`Strings#toRootUpperCase`](https://logging.apache.org/log4j/2.x/javadoc/log4j-api/org/apache/logging/log4j/util/Strings.html#toRootUpperCase-java.lang.String-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Fix locale-dependent `toLowerCase()/toUpperCase()` calls (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #1281:
URL: https://github.com/apache/logging-log4j2/issues/1281#issuecomment-1493691297

   @akashshirale14,
   
   Done. I also updated the issue description: we already have methods `Strings#toRootLowerCase/toRootUpperCase` that sound less English-centric and do the same thing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Fix locale-dependent `toLowerCase()/toUpperCase()` calls (logging-log4j2)

Posted by "akashshirale14 (via GitHub)" <gi...@apache.org>.
akashshirale14 commented on issue #1281:
URL: https://github.com/apache/logging-log4j2/issues/1281#issuecomment-1493676721

   Can you assign this issue to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org