[jira] [Commented] (OPENNLP-1219) change private instance variable featureGenerators to protected in DefaultNameContextGenerator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620256#comment-16620256 ] 

ASF GitHub Bot commented on OPENNLP-1219:
-----------------------------------------

kojisekig opened a new pull request #333: OPENNLP-1219: change private instance variable featureGenerators to p…
URL: https://github.com/apache/opennlp/pull/333
 
 
   …rotected in DefaultNameContextGenerator
   
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> change private instance variable featureGenerators to protected in DefaultNameContextGenerator
> ----------------------------------------------------------------------------------------------
>
>                 Key: OPENNLP-1219
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1219
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: 1.9.0
>            Reporter: Koji Sekiguchi
>            Priority: Minor
>
> TokenNameFinderTrainer allows users to customize TokenNameFinderFactory via -factory option. As I want to override DefaultNameContextGenerator.getContext(), I made the sub-class of TokenNameFinderFactory and created an instance of the sub-class of DefaultNameContextGenerator in the constructor of my TokenNameFinderFactory. However, I couldn't implement getContext() method of my DefaultNameContextGenerator because I couldn't access private member featureGenerators.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)