You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tvm.apache.org by driazati <no...@github.com.INVALID> on 2022/06/28 20:55:59 UTC

[apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/tvm/pull/11938

-- Commit Summary --

  * [ci][docker] Use RFC image tags only

-- File Changes --

    M tests/scripts/open_docker_update_pr.py (6)

-- Patch Links --

https://github.com/apache/tvm/pull/11938.patch
https://github.com/apache/tvm/pull/11938.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938
You are receiving this because you are subscribed to this thread.

Message ID: &lt;apache/tvm/pull/11938@github.com&gt;

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by driazati <no...@github.com.INVALID>.

it ignores any extra images that someone might manually push (or the validated ones that get pushed by ci with the name `123-123-abc-validated`)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1183584180
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by Andrew Reusch <no...@github.com.INVALID>.

@driazati could you give a bit more context here? is there a bug describing what's wrong right now?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1182050322
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by "github-actions[bot]" <no...@github.com.INVALID>.

<!---docs-bot-comment-->

Built docs for commit 28d0ba9ba7f7353789fb608880b833087491e3fd can be found [here](https://pr-docs.tlcpack.ai/PR-11938/2/docs/index.html).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1171730426
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by "github-actions[bot]" <no...@github.com.INVALID>.

It has been a while since this PR was updated, @areusch @Mousius please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please [convert it to a draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft) until it is ready for review.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1190661613
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by Andrew Reusch <no...@github.com.INVALID>.

Merged #11938 into main.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#event-7076836620
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by Florin Blanaru <no...@github.com.INVALID>.

> @gigiblender could you review this one so you can understand how this tool works?

@areusch Sure

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1193596507
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by "github-actions[bot]" <no...@github.com.INVALID>.

It has been a while since this PR was updated, @Mousius @areusch please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please [convert it to a draft](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft) until it is ready for review.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1179123573
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by Andrew Reusch <no...@github.com.INVALID>.

@gigiblender could you review this one so you can understand how this tool works?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1193593317
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [ci][docker] Use RFC image tags only (PR #11938)

Posted by Florin Blanaru <no...@github.com.INVALID>.

Thanks @driazati! LGTM!

@areusch 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1195513761
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>