You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/11/22 05:42:56 UTC
[GitHub] incubator-beam pull request #1411: [BEAM-25] Temporarily reject stateful Par...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1411
[BEAM-25] Temporarily reject stateful ParDo in ApexRunner (until support is added)
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @bjchambers
At present, the user-facing API for stateful `DoFn` is in the codebase but prevented from use. It is `ParDo.of(...)` that rejects stateful `DoFn`. In #1399 I am removing this rejection, so I need to add it to all runners until they support the API.
I have also added a JUnit category so runners can exclude this from their `RunnableOnService` test suites.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam DataflowRunner-state
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1411.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1411
----
commit c9640ea08e8078752a51508430c3661555c4c8a7
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-16T05:35:03Z
Reject stateful DoFn in DataflowRunner
commit 7b7d2dd30ee7bf56fddaa221386f1046875176b1
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-21T23:41:13Z
Add JUnit category for stateful ParDo tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1411: [BEAM-25] Temporarily reject stateful Par...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1411
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---