You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Viraj Jasani (Jira)" <ji...@apache.org> on 2019/09/07 04:20:00 UTC

[jira] [Comment Edited] (HBASE-22460) Reopen a region if store reader references may have leaked

    [ https://issues.apache.org/jira/browse/HBASE-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922420#comment-16922420 ] 

Viraj Jasani edited comment on HBASE-22460 at 9/7/19 4:19 AM:
--------------------------------------------------------------

In the attached patch, the default store ref count threshold is kept 256(may be too high?). Would like to change this number based on recommendation.

Please review the patch.


was (Author: vjasani):
In the attached patch, the default store ref count threshold is kept 256. Would like to change this number based on recommendation. Please review the patch.

> Reopen a region if store reader references may have leaked
> ----------------------------------------------------------
>
>                 Key: HBASE-22460
>                 URL: https://issues.apache.org/jira/browse/HBASE-22460
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0, 1.5.0, 2.3.0
>            Reporter: Andrew Purtell
>            Assignee: Viraj Jasani
>            Priority: Minor
>             Fix For: 3.0.0, 1.5.0, 2.3.0
>
>         Attachments: HBASE-22460.master.000.patch
>
>
> We can leak store reader references if a coprocessor or core function somehow opens a scanner, or wraps one, and then does not take care to call close on the scanner or the wrapped instance. A reasonable mitigation for a reader reference leak would be a fast reopen of the region on the same server (initiated by the RS) This will release all resources, like the refcount, leases, etc. The clients should gracefully ride over this like any other region transition. This reopen would be like what is done during schema change application and ideally would reuse the relevant code. If the refcount is over some ridiculous threshold this mitigation could be triggered along with a fat WARN in the logs. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)