You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/03 08:57:00 UTC
[GitHub] [flink] TisonKun commented on a change in pull request #10392:
[FLINK-14854][client] Add executeAsync() method to execution environments
TisonKun commented on a change in pull request #10392: [FLINK-14854][client] Add executeAsync() method to execution environments
URL: https://github.com/apache/flink/pull/10392#discussion_r353050400
##########
File path: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/CollectionTestEnvironment.java
##########
@@ -42,11 +42,6 @@ public JobExecutionResult getLastJobExecutionResult() {
}
}
- @Override
- public JobExecutionResult execute() throws Exception {
Review comment:
IMO `execute()` should be a thin interface for adding default parameter, so we should mark it as `final` and this override makes non-sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services