[jira] [Commented] (NIFI-5420) Allow StandardProcessSession to calculate duration for provenance events

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542211#comment-16542211 ] 

ASF GitHub Bot commented on NIFI-5420:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2886

    NIFI-5420: Allow StandardProcessSession to calculate duration for provenance events

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-5420

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2886
    
----
commit c9aa7caae52eda571a36cabbbf6829bc15583f3b
Author: Matthew Burgess <ma...@...>
Date:   2018-07-12T21:13:32Z

    NIFI-5420: Allow StandardProcessSession to calculate duration for provenance events

----


> Allow StandardProcessSession to calculate duration for provenance events
> ------------------------------------------------------------------------
>
>                 Key: NIFI-5420
>                 URL: https://issues.apache.org/jira/browse/NIFI-5420
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> Besides some automatic provenance events being emitted by the framework, the onus is on each processor to register provenance events and to provide a duration for the amount of time spent on the operation that results in the provenance event(s). However, supplying the duration is not mandatory, and if not provided, a value of -1 is stored to indicate that the duration is unknown.
> Unfortunately there are many processors that do not track the operation time and thus do not store it in the provenance event. However, the time from when a flow file is fetched or created in a session to the time the provenance event is recorded is a legitimate measure of the time the flow file spent "active" in the session, which is the same as the duration of a provenance event.
> This Jira proposes to record the "start" time of each flow file (more specifically, it's StandardRepositoryRecord), and upon session.commit(), record the duration of the flow file while active in the session into the provenance event(s), only if the duration has not already been supplied to the provenance events.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)