[GitHub] sijie commented on a change in pull request #993: PendingReadOp: improve logging for speculative read targets

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #993: PendingReadOp: improve logging for speculative read targets
URL: https://github.com/apache/bookkeeper/pull/993#discussion_r161940675
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
 ##########
 @@ -254,9 +255,10 @@ public String toString() {
                 @Override
                 public Boolean call() throws Exception {
                     if (!isComplete() && null != maybeSendSpeculativeRead(heardFromHostsBitSet)) {
-                        if (LOG.isDebugEnabled()) {
-                            LOG.debug("Send speculative read for {}. Hosts heard are {}, ensemble is {}.",
-                                    this, heardFromHostsBitSet, ensemble);
+                        if (LOG.isInfoEnabled()) {
 
 Review comment:
   Are we sure changing this from debug to info? At a high load cluster, you might have 5-10% or even more traffic do speculative reads to ensure predictable latency. This change will result in producing a lot of unnecessary logging. 
   
   May I ask you a question? How useful this logging helps you guys at production?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services