You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Szehon Ho <sz...@cloudera.com> on 2013/11/23 02:23:05 UTC
Review Request 15816: HIVE-3181 getDatabaseMajor/Minor version does not
return values
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15816/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-3181
https://issues.apache.org/jira/browse/HIVE-3181
Repository: hive-git
Description
-------
This will parse the database version to determine the major and minor versions.
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 7b1c9da
jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java c447d44
jdbc/src/java/org/apache/hive/jdbc/Utils.java 4d75d98
Diff: https://reviews.apache.org/r/15816/diff/
Testing
-------
Thanks,
Szehon Ho
Re: Review Request 15816: HIVE-3181 getDatabaseMajor/Minor version does not
return values
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15816/#review29348
-----------------------------------------------------------
Ship it!
Ship It!
- Navis Ryu
On Nov. 23, 2013, 1:40 a.m., Szehon Ho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15816/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2013, 1:40 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-3181
> https://issues.apache.org/jira/browse/HIVE-3181
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> This will parse the database version to determine the major and minor versions.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 7b1c9da
> jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573
> jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java c447d44
> jdbc/src/java/org/apache/hive/jdbc/Utils.java 4d75d98
>
> Diff: https://reviews.apache.org/r/15816/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Szehon Ho
>
>
Re: Review Request 15816: HIVE-3181 getDatabaseMajor/Minor version does not
return values
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15816/
-----------------------------------------------------------
(Updated Nov. 23, 2013, 1:40 a.m.)
Review request for hive.
Changes
-------
Made a small optimization to lazily cache the db version number. This will decrease RPC calls to server, if more than one getXXVersion() method is called.
Bugs: HIVE-3181
https://issues.apache.org/jira/browse/HIVE-3181
Repository: hive-git
Description
-------
This will parse the database version to determine the major and minor versions.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 7b1c9da
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573
jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java c447d44
jdbc/src/java/org/apache/hive/jdbc/Utils.java 4d75d98
Diff: https://reviews.apache.org/r/15816/diff/
Testing
-------
Thanks,
Szehon Ho