You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2025/10/14 14:28:33 UTC
[PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
zhztheplayer opened a new pull request, #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883
#10874
The PR adds a documentation to demonstrate how to generate a complete release for a specific Gluten version locally.
The steps should be repeatable as long as the environment meets the prerequisites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2435123138
##########
dev/release/package-release.sh:
##########
@@ -15,7 +15,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside.
+# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/.
Review Comment:
Thanks for the insights. Now I think I am convinced we should go with a release manager guide first.
RE50 itself was seen a bit ambiguous and you are right it might better to read it as "creating new releases" rather than "reproducing old releases".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2444488514
##########
docs/developers/HowToRelease.md:
##########
@@ -0,0 +1,76 @@
+---
+layout: page
+title: How to Release
+nav_order: 17
+parent: Getting-Started
Review Comment:
It seems there are quite some issues with the current nav orders.
I am working on a fix which can be merged prior to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#issuecomment-3420280358
> Here is the update of the PR:
>
> 1. I've left `package-release.sh` nearly intact and changed the `HowToRelease.md` to do an extra copy from `package/target` to `release`
> 2. I've moved the release publication guide from `incubator-gluten-site`'s 1.3 branch to this documentation
>
> @PHILO-HE and feel free to help update `HowToRelease.md` about using the CI job to obtain release binaries in later PRs if that works for you. I think I can help either. This PR should first close RE50 then.
@zhztheplayer, thanks for your work. I will update the doc in separate PRs for better clarity according to the recent release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2434748751
##########
dev/release/package-release.sh:
##########
@@ -15,7 +15,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside.
+# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/.
Review Comment:
@zhztheplayer, thank you for the reply. I am not sure if users really need to create an official-like release by themselves. In official release, we build Gluten for all supported Spark versions with all feature modules enabled, even though generally some of them are not enabled together by users (e.g., Celeborn and Uniffle). However, most Gluten users only focus on one specific Spark version, and some of the the feature modules, which means they just need a clear build guide, not a release guide. Users like cloud service providers may require building releases for multi-Spark-version support. But they likely maintain their own processes and scripts to customize releases for forked repositories, which I assume differs significantly from our official release process.
If my understanding is correct, maybe we can focus only on the official release process, primarily for release managers' reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "weiting-chen (via GitHub)" <gi...@apache.org>.
weiting-chen commented on PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#issuecomment-3405486067
Please also copy the below file into incubator-gluten's doc, I noted we only put this md in the incubator-gluten-site repository and missed to add it in the main documentation.
The release process not only include how to compile, but also include releasing to Apache repository, voting, and more.
https://github.com/apache/incubator-gluten-site/blob/main/_docs/v1.3.0/developers/HowToRelease.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#issuecomment-3405563302
> The release process not only include how to compile, but also include releasing to Apache repository, voting, and more.
@weiting-chen, I understand this. This doc is initialized for new users to generate artifact sets by themselves. I'll see how to organize the user and release manager guide later on.
For release managers, they are usually committers, so could conveniently invoke the GitHub Actions jobs to create the assets. For users, they have to build from source. It's the reason that we may finally need separate guides here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2431001044
##########
dev/release/package-release.sh:
##########
@@ -15,7 +15,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside.
+# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/.
Review Comment:
I have created one GHA job to build Gluten, and then upload the JARs. The job is auto triggered when tag like v1.5.0-rc0 is created in the repo.
https://github.com/apache/incubator-gluten/actions/runs/18470382803/job/52622515460
So $GLUTEN_HOME/release/ is used to manually place the JARs. The JARs can be obtained from either the above GHA job (recommended) or manual build.
##########
docs/get-started/CreateRelease.md:
##########
Review Comment:
Can we move this doc to `dev/release/` together with the release scripts? I think this doc is primarily for release managers' reference. So it seems not necessary to expose it to broader readers by putting it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2431873773
##########
dev/release/package-release.sh:
##########
@@ -15,7 +15,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside.
+# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/.
Review Comment:
Hi @PHILO-HE,
> I have created one GHA job to build Gluten, and then upload the JARs.
I believe there are two separate things we need:
1. Guide for user to create a release by themself
2. Guide for release manager to publish a release
For users, they don't usually have the immediate permission to run the GitHub Actions jobs. So we need provide a way for them to create the release artifacts from the source code.
I can leave the `$GLUTEN_HOME/release/` solution unchanged but add an extra copy-paste step in the documentation. Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2443679858
##########
docs/developers/HowToRelease.md:
##########
@@ -0,0 +1,76 @@
+---
+layout: page
+title: How to Release
+nav_order: 17
+parent: Getting-Started
Review Comment:
@zhztheplayer, could you change the `nav_order` and `parent`? I assume they are applicable for the previous doc location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#issuecomment-3418802943
Here is the update of the PR:
1. I've left `package-release.sh` nearly intact and changed the `HowToRelease.md` to do an extra copy from `package/target` to `release`
2. I've moved the release publication guid from `incubator-gluten-site`'s 1.3 branch to this documentation
@PHILO-HE And feel free to help update `HowToRelease.md` to use the CI job to obtain release binaries afterwards. This PR should close RE50 then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#issuecomment-3402560584
@PHILO-HE @zhouyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2431873773
##########
dev/release/package-release.sh:
##########
@@ -15,7 +15,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside.
+# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/.
Review Comment:
Hi @PHILO-HE,
> I have created one GHA job to build Gluten, and then upload the JARs.
I believe there are two separate things we need:
1. Guide for user to create a release by themself ([RE50](https://community.apache.org/apache-way/apache-project-maturity-model.html#releases))
2. Guide for release manager to publish a release (better to have?)
For users, they don't usually have the immediate permission to run the GitHub Actions jobs. So we need provide a way for them to create a release from the source code.
I can leave the `$GLUTEN_HOME/release/` solution unchanged but add an extra copy-paste step in the documentation. Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2436647043
##########
dev/release/package-release.sh:
##########
Review Comment:
@zhztheplayer, could you please include the following changes? I have applied these changes in the recently RC. It's for meeting the release requirement (The approved release candidate will be directly converted to a formal release. So "rc*" shouldn't be used in naming packaged folders).
```diff
diff --git a/dev/release/package-release.sh b/dev/release/package-release.sh
index ec18101ae..d60a14e78 100755
--- a/dev/release/package-release.sh
+++ b/dev/release/package-release.sh
@@ -53,11 +53,14 @@ for v in $SPARK_VERSIONS; do
done
SRC_ZIP="${TAG}.zip"
-SRC_DIR="incubator-gluten-${TAG_VERSION}"
+SRC_DIR="incubator-gluten-${RELEASE_VERSION}"
echo "Packaging source code..."
wget https://github.com/apache/incubator-gluten/archive/refs/tags/${SRC_ZIP}
unzip -q ${SRC_ZIP}
+
+# Rename folder to remove "rc*" for formal release.
+mv incubator-gluten-${TAG_VERSION} ${SRC_DIR}
tar -czf apache-gluten-${RELEASE_VERSION}-incubating-src.tar.gz ${SRC_DIR}
rm -r ${SRC_ZIP} ${SRC_DIR}
```
##########
docs/developers/HowToRelease.md:
##########
@@ -0,0 +1,76 @@
+---
+layout: page
+title: How to Release
+nav_order: 17
+parent: Getting-Started
Review Comment:
Please update accordingly. Thanks.
##########
docs/developers/HowToRelease.md:
##########
Review Comment:
Sounds good to me. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2444558271
##########
docs/developers/HowToRelease.md:
##########
@@ -0,0 +1,76 @@
+---
+layout: page
+title: How to Release
+nav_order: 17
+parent: Getting-Started
Review Comment:
> It seems there are quite some issues with the current nav orders.
Unfortunately, after a quick check, I think I need more time for doing this.
I've update the PR to make the new page correctly show up, so we can merge this first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2444558271
##########
docs/developers/HowToRelease.md:
##########
@@ -0,0 +1,76 @@
+---
+layout: page
+title: How to Release
+nav_order: 17
+parent: Getting-Started
Review Comment:
> It seems there are quite some issues with the current nav orders.
Unfortunately, after a quick check, I think I need more time for fixing this.
I've update the PR to make the new page correctly show up, so we can merge this first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2431873773
##########
dev/release/package-release.sh:
##########
@@ -15,7 +15,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside.
+# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/.
Review Comment:
Hi @PHILO-HE,
> I have created one GHA job to build Gluten, and then upload the JARs.
I believe there are two separate things we need:
1. Guide for user to create a release by themself ([RE50](https://community.apache.org/apache-way/apache-project-maturity-model.html#releases))
2. Guide for release manager to publish a release (better to have?)
For users, they don't usually have the immediate permission to run the GitHub Actions jobs. So we need provide a way for them to create the release artifacts from the source code.
I can leave the `$GLUTEN_HOME/release/` solution unchanged but add an extra copy-paste step in the documentation. Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2435137851
##########
docs/developers/HowToRelease.md:
##########
Review Comment:
I think we'd better publish it to the website. This could let more people know how we handle the releases, even if they are not developers or release managers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2436647043
##########
dev/release/package-release.sh:
##########
Review Comment:
@zhztheplayer, could you please include the following changes? I have applied these changes when publishing the recent 1.5.0 RC1. It's for meeting the release requirement (The approved release candidate will be directly converted to a formal release. So "rc*" shouldn't be used in naming packaged folders).
```diff
diff --git a/dev/release/package-release.sh b/dev/release/package-release.sh
index ec18101ae..d60a14e78 100755
--- a/dev/release/package-release.sh
+++ b/dev/release/package-release.sh
@@ -53,11 +53,14 @@ for v in $SPARK_VERSIONS; do
done
SRC_ZIP="${TAG}.zip"
-SRC_DIR="incubator-gluten-${TAG_VERSION}"
+SRC_DIR="incubator-gluten-${RELEASE_VERSION}"
echo "Packaging source code..."
wget https://github.com/apache/incubator-gluten/archive/refs/tags/${SRC_ZIP}
unzip -q ${SRC_ZIP}
+
+# Rename folder to remove "rc*" for formal release.
+mv incubator-gluten-${TAG_VERSION} ${SRC_DIR}
tar -czf apache-gluten-${RELEASE_VERSION}-incubating-src.tar.gz ${SRC_DIR}
rm -r ${SRC_ZIP} ${SRC_DIR}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#issuecomment-3405758317
> I noted we only put this md in the incubator-gluten-site repository and missed to add it in the main documentation.
We need a synchronizer between the two repos. I will look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#issuecomment-3405719976
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-10874][INFRA] Maturity RE50: In documentation, add a section for the release process [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2444563812
##########
docs/developers/HowToRelease.md:
##########
@@ -0,0 +1,76 @@
+---
+layout: page
+title: How to Release
+nav_order: 17
+parent: Getting-Started
Review Comment:
> nav_order: 17
`nav_order: 17` was intentional to make it be the last so safe to display. I will find the doc a better order in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org