You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org> on 2023/09/13 12:01:51 UTC
[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #515: [SYNCOPE-1776] Using ES BulkRequest for re-index
github-code-scanning[bot] commented on code in PR #515:
URL: https://github.com/apache/syncope/pull/515#discussion_r1324405227
##########
ext/elasticsearch/client-elasticsearch/src/main/java/org/apache/syncope/ext/elasticsearch/client/ElasticsearchUtils.java:
##########
@@ -204,18 +184,13 @@
return builder;
}
- protected void customizeDocument(
- final Map<String, Object> builder, final AnyObject anyObject, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final AnyObject anyObject) {
}
- protected void customizeDocument(
- final Map<String, Object> builder, final Group group, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final Group group) {
Review Comment:
## Useless parameter
The parameter 'builder' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1353)
##########
ext/elasticsearch/client-elasticsearch/src/main/java/org/apache/syncope/ext/elasticsearch/client/ElasticsearchUtils.java:
##########
@@ -204,18 +184,13 @@
return builder;
}
- protected void customizeDocument(
- final Map<String, Object> builder, final AnyObject anyObject, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final AnyObject anyObject) {
}
- protected void customizeDocument(
- final Map<String, Object> builder, final Group group, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final Group group) {
}
- protected void customizeDocument(final Map<String, Object> builder, final User user, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final User user) {
Review Comment:
## Useless parameter
The parameter 'builder' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1351)
##########
ext/elasticsearch/client-elasticsearch/src/main/java/org/apache/syncope/ext/elasticsearch/client/ElasticsearchUtils.java:
##########
@@ -204,18 +184,13 @@
return builder;
}
- protected void customizeDocument(
- final Map<String, Object> builder, final AnyObject anyObject, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final AnyObject anyObject) {
}
- protected void customizeDocument(
- final Map<String, Object> builder, final Group group, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final Group group) {
}
- protected void customizeDocument(final Map<String, Object> builder, final User user, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final User user) {
Review Comment:
## Useless parameter
The parameter 'user' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1352)
##########
ext/elasticsearch/client-elasticsearch/src/main/java/org/apache/syncope/ext/elasticsearch/client/ElasticsearchUtils.java:
##########
@@ -204,18 +184,13 @@
return builder;
}
- protected void customizeDocument(
- final Map<String, Object> builder, final AnyObject anyObject, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final AnyObject anyObject) {
Review Comment:
## Useless parameter
The parameter 'anyObject' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1356)
##########
ext/elasticsearch/client-elasticsearch/src/main/java/org/apache/syncope/ext/elasticsearch/client/ElasticsearchUtils.java:
##########
@@ -204,18 +184,13 @@
return builder;
}
- protected void customizeDocument(
- final Map<String, Object> builder, final AnyObject anyObject, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final AnyObject anyObject) {
}
- protected void customizeDocument(
- final Map<String, Object> builder, final Group group, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final Group group) {
Review Comment:
## Useless parameter
The parameter 'group' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1354)
##########
ext/elasticsearch/client-elasticsearch/src/main/java/org/apache/syncope/ext/elasticsearch/client/ElasticsearchUtils.java:
##########
@@ -204,18 +184,13 @@
return builder;
}
- protected void customizeDocument(
- final Map<String, Object> builder, final AnyObject anyObject, final String domain)
- throws IOException {
+ protected void customizeDocument(final Map<String, Object> builder, final AnyObject anyObject) {
Review Comment:
## Useless parameter
The parameter 'builder' is never used.
[Show more details](https://github.com/apache/syncope/security/code-scanning/1355)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org