[GitHub] tswast commented on a change in pull request #3838: [AIRFLOW-2997] Support for Bigquery clustered tables

[GitBox <gi...@apache.org>]

tswast commented on a change in pull request #3838: [AIRFLOW-2997] Support for Bigquery clustered tables
URL: https://github.com/apache/incubator-airflow/pull/3838#discussion_r215441683
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -671,6 +680,15 @@ def run_query(self,
                     self.log.info("Adding experimental 'schemaUpdateOptions': "
                                   "{0}".format(schema_update_options))
 
+                if param_name == 'clustering' and param:
+                    # given the ordering of the query_params_list above,
+                    # if time_partitioning is configured, it will now be in the
+                    # query resource
+                    if 'timePartitioning' not in configuration['query']:
 
 Review comment:
   I'd prefer removing client-side validation such as this, since the BigQuery API may change this and similar restrictions in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services