You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jfrag1 (via GitHub)" <gi...@apache.org> on 2023/04/05 01:09:31 UTC
[GitHub] [superset] jfrag1 opened a new pull request, #23582: fix(dash import): Ensure old datasource ids is not referenced in imported charts
jfrag1 opened a new pull request, #23582:
URL: https://github.com/apache/superset/pull/23582
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Currently, charts imported via a dashboard import contain references to the chart's old datasource id from when it was exported within their `params` and `query_context`. This didn't result in any functionality breaking, but it would result in the following "false alarm" error message when loading the dashboard:
There is precedent for this fix in the individual chart import, see here: https://github.com/apache/superset/blob/master/superset/charts/commands/importers/v1/__init__.py#L96
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23582: fix(dash import): Ensure old datasource ids are not referenced in imported charts
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23582:
URL: https://github.com/apache/superset/pull/23582#issuecomment-1496794309
## [Codecov](https://codecov.io/gh/apache/superset/pull/23582?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23582](https://codecov.io/gh/apache/superset/pull/23582?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (efb1275) into [master](https://codecov.io/gh/apache/superset/commit/9d2f43d312c37c8c6827c2f94de6b5e3e1431014?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d2f43d) will **decrease** coverage by `11.35%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head efb1275 differs from pull request most recent head a2bb048. Consider uploading reports for the commit a2bb048 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23582 +/- ##
===========================================
- Coverage 67.71% 56.37% -11.35%
===========================================
Files 1916 1916
Lines 74014 74019 +5
Branches 8039 8039
===========================================
- Hits 50122 41726 -8396
- Misses 21843 30244 +8401
Partials 2049 2049
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.66% <0.00%> (-0.01%)` | :arrow_down: |
| python | `58.95% <0.00%> (-23.47%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.62% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/23582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `32.87% <0.00%> (-65.66%)` | :arrow_down: |
... and [301 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23582/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #23582: fix(dash import): Ensure old datasource ids are not referenced in imported charts
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida merged PR #23582:
URL: https://github.com/apache/superset/pull/23582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] santosh-sahoo334 commented on pull request #23582: fix(dash import): Ensure old datasource ids are not referenced in imported charts
Posted by "santosh-sahoo334 (via GitHub)" <gi...@apache.org>.
santosh-sahoo334 commented on PR #23582:
URL: https://github.com/apache/superset/pull/23582#issuecomment-1543405811
Thanks! I was exactly looking for this. So If I import any dashboard from let say 1.5.1 to 2.1.1, it should not produce the false alarm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org