You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tim Ellison (JIRA)" <ji...@apache.org> on 2009/09/03 12:51:40 UTC
[jira] Resolved: (HARMONY-6323) [classlib] [luni] Simplify and
speed-up collection shuffle, add a non-probabilistic test
[ https://issues.apache.org/jira/browse/HARMONY-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-6323.
----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M12
Thanks Jesse.
Patch applied to LUNI module at repo revision r810887.
Please verify it was applied as you expected.
> [classlib] [luni] Simplify and speed-up collection shuffle, add a non-probabilistic test
> ----------------------------------------------------------------------------------------
>
> Key: HARMONY-6323
> URL: https://issues.apache.org/jira/browse/HARMONY-6323
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: SVN Revision 801399
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Priority: Minor
> Fix For: 5.0M12
>
> Attachments: Shuffle-fixes.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Shuffle needlessly tests Random.nextInt() for a negative value
> It iterates from index N-1 to 0, which means it always swaps index 0 with itself needlessly.
> It is only tested with probabilistic tests, the patch adds a proper test. Note that the attached test also passes on the RI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.