You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "fabikd (via GitHub)" <gi...@apache.org> on 2023/05/08 13:43:40 UTC
[GitHub] [trafficcontrol] fabikd opened a new pull request, #7495: Add health client
fabikd opened a new pull request, #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Documentation
- Traffic Control Cache Config (`t3c`, formerly ORT)
- Traffic Control Health Client (tc-health-client)
- Traffic Control Client <!-- Please specify which (Python, Go, or Java) -->
- Traffic Monitor
- Traffic Ops
- Traffic Portal
- Traffic Router
- Traffic Stats
- Grove
- CDN in a Box
- Automation <!-- Please specify which (GitHub Actions, Docker images, Ansible Roles, etc.) -->
- unknown
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Adds tc-health-client to cdn-in-a-box, fix to show the fqdn instead of hostname and enabled logging sending it to the default log file instead of /dev/null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] fabikd commented on a diff in pull request #7495: Adds tc-health-client to CDN-in-a-Box
Posted by "fabikd (via GitHub)" <gi...@apache.org>.
fabikd commented on code in PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#discussion_r1237438789
##########
infrastructure/cdn-in-a-box/health/tc-health-client.json:
##########
@@ -1,9 +1,10 @@
{
- "cdn-name": "over-the-top",
+ "cdn-name": "mycdn",
Review Comment:
Done!! (:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jpappa200 commented on a diff in pull request #7495: Adds tc-health-client to CDN-in-a-Box
Posted by "jpappa200 (via GitHub)" <gi...@apache.org>.
jpappa200 commented on code in PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#discussion_r1237386100
##########
infrastructure/cdn-in-a-box/health/tc-health-client.json:
##########
@@ -1,9 +1,10 @@
{
- "cdn-name": "over-the-top",
+ "cdn-name": "mycdn",
Review Comment:
This should be `CDN-in-a-Box`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 merged pull request #7495: Adds tc-health-client to CDN-in-a-Box
Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 merged PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] fabikd commented on pull request #7495: Adds tc-health-client to CDN-in-a-Box
Posted by "fabikd (via GitHub)" <gi...@apache.org>.
fabikd commented on PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#issuecomment-1591401544
pr name updated! (:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7495: Add health client
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#issuecomment-1538634277
## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7495?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7495](https://app.codecov.io/gh/apache/trafficcontrol/pull/7495?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8eba40) into [master](https://app.codecov.io/gh/apache/trafficcontrol/commit/29a6832dd633621a5211f6bb5439d6bbb4fd91ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29a6832) will **decrease** coverage by `0.88%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #7495 +/- ##
============================================
- Coverage 32.87% 32.00% -0.88%
Complexity 98 98
============================================
Files 493 497 +4
Lines 50156 39251 -10905
Branches 790 90 -700
============================================
- Hits 16491 12563 -3928
+ Misses 32464 25523 -6941
+ Partials 1201 1165 -36
```
| Flag | Coverage Δ | |
|---|---|---|
| golib_unit | `48.58% <ø> (?)` | |
| grove_unit | `4.60% <ø> (?)` | |
| t3c_unit | `5.32% <ø> (?)` | |
| traffic_monitor_unit | `21.28% <ø> (?)` | |
| traffic_ops_unit | `?` | |
| traffic_portal_v2 | `?` | |
| traffic_stats_unit | `10.14% <ø> (?)` | |
| unit_tests | `25.55% <ø> (-2.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/trafficcontrol/pull/7495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/go-log/log.go](https://app.codecov.io/gh/apache/trafficcontrol/pull/7495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2dvLWxvZy9sb2cuZ28=) | `16.43% <ø> (ø)` | |
... and [578 files with indirect coverage changes](https://app.codecov.io/gh/apache/trafficcontrol/pull/7495/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on pull request #7495: Add health client
Posted by "mitchell852 (via GitHub)" <gi...@apache.org>.
mitchell852 commented on PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#issuecomment-1586403708
@fabikd would you mind making the PR title more descriptive? maybe "Adds tc-health-client to CDN-in-a-Box"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] fabikd commented on pull request #7495: Add health client
Posted by "fabikd (via GitHub)" <gi...@apache.org>.
fabikd commented on PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#issuecomment-1585114722
Hi Joe!!! I just pushed a fix for the error we were seeing in the cdn-in-a-box finding the traffic_monitor. This will look for it with an underscore`RASCAL_Traffic_Monitor` instead of `RASCAL-Traffic_Monitor` and I populated the `/etc/to-creds` with the cdn-in-a-box creds!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7495: Add health client
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#issuecomment-1539005827
Can you please add a description to this PR? As it stands, I have no idea what the intended change is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7495: Add health client
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#issuecomment-1539006092
Can you please add a description to this PR? As it stands, I have no idea what the intended change is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] fabikd commented on pull request #7495: Add health client
Posted by "fabikd (via GitHub)" <gi...@apache.org>.
fabikd commented on PR #7495:
URL: https://github.com/apache/trafficcontrol/pull/7495#issuecomment-1539212518
sure!! (: it was under the pr submission checklist. But it was hard to see, my fault. Here it is:
Adds tc-health-client to cdn-in-a-box, fix to show the fqdn instead of hostname and enabled logging sending it to the default log file instead of /dev/null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org