You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/02/22 14:43:28 UTC

Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.


Description
-------

When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.


This addresses bug CLOUDSTACK-1374.


Diffs
-----

  server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java e12bc32 

Diff: https://reviews.apache.org/r/9558/diff/


Testing
-------

Verified the fix on my local CloudStack setup.


Thanks,

Sanjay Tripathi

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Nitin Mehta <ni...@citrix.com>.


> On Feb. 26, 2013, 5:09 a.m., Nitin Mehta wrote:
> > Ship It!

Pushed with commit 10236bee26f79391838c103972d0afa551e5efd4


- Nitin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/#review17072
-----------------------------------------------------------


On Feb. 25, 2013, 4:15 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9558/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 4:15 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min Chen.
> 
> 
> Description
> -------
> 
> When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.
> 
> 
> This addresses bug CLOUDSTACK-1374.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 1fd1996 
> 
> Diff: https://reviews.apache.org/r/9558/diff/
> 
> 
> Testing
> -------
> 
> Verified the fix on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Abhinandan Prateek <Ab...@citrix.com>.

I think ship it code should be committed too. After which the contributor
should close the review request.

On 26/02/13 10:39 AM, "Nitin Mehta" <ni...@citrix.com> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/9558/#review17072
>-----------------------------------------------------------
>
>Ship it!
>
>
>Ship It!

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Nitin Mehta <ni...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/#review17072
-----------------------------------------------------------

Ship it!


Ship It!

- Nitin Mehta


On Feb. 25, 2013, 4:15 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9558/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 4:15 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min Chen.
> 
> 
> Description
> -------
> 
> When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.
> 
> 
> This addresses bug CLOUDSTACK-1374.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 1fd1996 
> 
> Diff: https://reviews.apache.org/r/9558/diff/
> 
> 
> Testing
> -------
> 
> Verified the fix on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Devdeep Singh <de...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/#review17074
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On Feb. 25, 2013, 4:15 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9558/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 4:15 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min Chen.
> 
> 
> Description
> -------
> 
> When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.
> 
> 
> This addresses bug CLOUDSTACK-1374.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 1fd1996 
> 
> Diff: https://reviews.apache.org/r/9558/diff/
> 
> 
> Testing
> -------
> 
> Verified the fix on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Sanjay Tripathi <sa...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 4:15 p.m.)


Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min Chen.


Changes
-------

Updated patch as per review comments.


Description
-------

When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.


This addresses bug CLOUDSTACK-1374.


Diffs (updated)
-----

  server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java 1fd1996 

Diff: https://reviews.apache.org/r/9558/diff/


Testing
-------

Verified the fix on my local CloudStack setup.


Thanks,

Sanjay Tripathi

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Nitin Mehta <Ni...@citrix.com>.

True, but you should check that the size is not already set. If it is set then you shouldn't update the DB

From: Sanjay Tripathi <sa...@citrix.com>>
Reply-To: Sanjay Tripathi <sa...@citrix.com>>
To: Sateesh Chodapuneedi <sa...@citrix.com>>, "mice_xia@tcloudcomputing.com<ma...@tcloudcomputing.com>" <mi...@tcloudcomputing.com>>, Min Chen <mi...@citrix.com>>, Devdeep Singh <de...@citrix.com>>
Cc: Nitin Mehta <ni...@citrix.com>>, "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>, Sanjay Tripathi <sa...@citrix.com>>
Subject: Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9558/

On February 25th, 2013, 12:37 p.m., Nitin Mehta wrote:

server/src/com/cloud/storage/download/DownloadMonitorImpl.java<https://reviews.apache.org/r/9558/diff/1/?file=261150#file261150line742> (Diff revision 1)

{'text': 'public void handleVolumeSync(HostVO ssHost) {', 'line': 693, 'expand_offset': 18}

        742

                    // Set volume size in volumes table

What if the size is already set ? why do we need to set it again ?

This is for the final sync of volumes (same way we update the volume_host_ref table) in cases if the volume is not completely downloaded and MS is in shutdown state(this may be one case) etc.

- Sanjay

On February 25th, 2013, 12:31 p.m., Sanjay Tripathi wrote:

Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min Chen.
By Sanjay Tripathi.

Updated Feb. 25, 2013, 12:31 p.m.

Description

When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.

Testing

Verified the fix on my local CloudStack setup.

Bugs: CLOUDSTACK-1374
Diffs

 *   server/src/com/cloud/storage/download/DownloadListener.java (d0b1868)
 *   server/src/com/cloud/storage/download/DownloadMonitorImpl.java (e12bc32)

View Diff<https://reviews.apache.org/r/9558/diff/>

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Sanjay Tripathi <sa...@citrix.com>.


> On Feb. 25, 2013, 12:37 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/storage/download/DownloadMonitorImpl.java, line 742
> > <https://reviews.apache.org/r/9558/diff/1/?file=261150#file261150line742>
> >
> >     What if the size is already set ? why do we need to set it again ?

This is for the final sync of volumes (same way we update the volume_host_ref table) in cases if the volume is not completely downloaded and MS is in shutdown state(this may be one case) etc.


- Sanjay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/#review17035
-----------------------------------------------------------


On Feb. 25, 2013, 12:31 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9558/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 12:31 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min Chen.
> 
> 
> Description
> -------
> 
> When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.
> 
> 
> This addresses bug CLOUDSTACK-1374.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java e12bc32 
> 
> Diff: https://reviews.apache.org/r/9558/diff/
> 
> 
> Testing
> -------
> 
> Verified the fix on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Nitin Mehta <ni...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/#review17035
-----------------------------------------------------------



server/src/com/cloud/storage/download/DownloadMonitorImpl.java
<https://reviews.apache.org/r/9558/#comment36084>

    What if the size is already set ? why do we need to set it again ?


- Nitin Mehta


On Feb. 25, 2013, 12:31 p.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9558/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 12:31 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min Chen.
> 
> 
> Description
> -------
> 
> When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.
> 
> 
> This addresses bug CLOUDSTACK-1374.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java e12bc32 
> 
> Diff: https://reviews.apache.org/r/9558/diff/
> 
> 
> Testing
> -------
> 
> Verified the fix on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

Posted by Sanjay Tripathi <sa...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9558/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 12:31 p.m.)


Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, mice xia, and Min Chen.


Description
-------

When user uploads a volume using uploadVolume API command, only volume_host_ref table is getting updated with corresponding size of volume and "volumes" table, the size of volume still remains zero even ager the volume gets completely downloaded.


This addresses bug CLOUDSTACK-1374.


Diffs
-----

  server/src/com/cloud/storage/download/DownloadListener.java d0b1868 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java e12bc32 

Diff: https://reviews.apache.org/r/9558/diff/


Testing
-------

Verified the fix on my local CloudStack setup.


Thanks,

Sanjay Tripathi