You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2025/03/10 18:17:36 UTC
[PR] chore: migrate Tabs component to use antd-v5 [superset]
mistercrunch opened a new pull request, #32570:
URL: https://github.com/apache/superset/pull/32570
This is WiP, incomplete!
I started migrating tabs but realized there are many more than I thought originally so want to open this DRAFT PR for cooperation / handoff.
My approach, step-by-step was to start by moving components using tabs to point to vanilla `antd-v5` alias one by one, while keeping `src/components/Tabs` untouched (as opposed to altering `src/components/Tabs` to point to `antd-v5` and fix the broken ones one-by-one). Once all were going to be migrated, I was planning on switching everything to make `src/components/Tabs` a very simple wrapper to `antd-v5` and pointing all of the components to it.
Looks like I did 7 so far, and there are 14 left to migrate:
```bash
$ git grep "src/components/Tabs"
src/SqlLab/components/TabbedSqlEditors/index.tsx:import { EditableTabs } from 'src/components/Tabs';
src/components/Chart/DrillBy/useResultsTableView.tsx:import Tabs from 'src/components/Tabs';
src/dashboard/components/BuilderComponentPane/index.tsx:import Tabs from 'src/components/Tabs';
src/dashboard/components/DashboardBuilder/DashboardContainer.tsx:import Tabs from 'src/components/Tabs';
src/dashboard/components/gridComponents/Tabs.jsx:import { LineEditableTabs } from 'src/components/Tabs';
src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:import Tabs from 'src/components/Tabs';
src/explore/components/controls/ColumnConfigControl/ColumnConfigPopover.tsx:import Tabs from 'src/components/Tabs';
src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:import Tabs from 'src/components/Tabs';
src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx:import Tabs from 'src/components/Tabs';
src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx:import Tabs from 'src/components/Tabs';
src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx:import Tabs from 'src/components/Tabs';
src/features/databases/DatabaseModal/index.tsx:import Tabs from 'src/components/Tabs';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: migrate Tabs component to use antd-v5 [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #32570:
URL: https://github.com/apache/superset/pull/32570#issuecomment-2711447762
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment `/korbit-review`.
> Your admin can change your review schedule in the [Korbit Console](https://app.korbit.ai/settings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: migrate Tabs component to use antd-v5 [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch closed pull request #32570: chore: migrate Tabs component to use antd-v5
URL: https://github.com/apache/superset/pull/32570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org