You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Yaytay (JIRA)" <ji...@apache.org> on 2011/05/16 15:29:47 UTC
[jira] [Created] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
KarArtifactInstaller::init has incorrect warning logic
------------------------------------------------------
Key: KARAF-643
URL: https://issues.apache.org/jira/browse/KARAF-643
Project: Karaf
Issue Type: Bug
Components: runtime
Affects Versions: 2.2.1, 2.2.0
Environment: Ubuntu Linux (though I believe the issue affects all platforms).
Reporter: Yaytay
Priority: Trivial
KarArtifactInstaller.java has the following block:
if (new File(timestampPath).mkdirs()) {
logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
}
which looks as though it's missing a !
mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Martin Lichtin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432690#comment-13432690 ]
Martin Lichtin commented on KARAF-643:
--------------------------------------
+1 The warning is definitely confusing:
2012-08-10 12:28:42,579 | WARN | rint Extender: 1 | KarArtifactInstaller | 33 - org.apache.karaf.deployer.kar - 2.2.8 | Unable to create directory for Karaf Archive timestamps. Results may vary...
2012-08-10 12:28:42,579 | INFO | rint Extender: 1 | KarArtifactInstaller | 33 - org.apache.karaf.deployer.kar - 2.2.8 | Karaf archives will be extracted to C:\Users\mli\nuc\sandbox\master\transaction\tx-reference\tx-ref-itests\target\paxexam\f8026a21-3205-4ac6-bb9a-22957e54dca1/system
2012-08-10 12:28:42,579 | INFO | rint Extender: 1 | KarArtifactInstaller | 33 - org.apache.karaf.deployer.kar - 2.2.8 | Timestamps for Karaf archives will be extracted to C:\Users\mli\nuc\sandbox\master\transaction\tx-reference\tx-ref-itests\target\paxexam\f8026a21-3205-4ac6-bb9a-22957e54dca1/system\.timestamps
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Priority: Trivial
> Fix For: 3.0.1, 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-643 started by Freeman Fang.
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Freeman Fang
> Priority: Trivial
> Fix For: 3.0.1, 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré updated KARAF-643:
---------------------------------------
Fix Version/s: 3.1.0
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: runtime
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré reassigned KARAF-643:
------------------------------------------
Assignee: (was: Jean-Baptiste Onofré)
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Priority: Trivial
> Fix For: 3.0.1, 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Michael Van Geertruy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Van Geertruy updated KARAF-643:
---------------------------------------
Attachment: karaf-643.txt
Patch for this bug.
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: runtime
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Priority: Trivial
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved KARAF-643.
--------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.1.0)
(was: 3.0.1)
2.3.0
2.2.9
commit fix per Chris Dolan's suggestion
http://svn.apache.org/viewvc?rev=1372227&view=rev for 2.3.x branch
http://svn.apache.org/viewvc?rev=1372221&view=rev for 2.2.x branch
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Freeman Fang
> Priority: Trivial
> Fix For: 2.2.9, 2.3.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré updated KARAF-643:
---------------------------------------
Component/s: (was: karaf-core)
karaf-kar
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Chris Dolan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253312#comment-13253312 ]
Chris Dolan commented on KARAF-643:
-----------------------------------
The patch should be "(!file.exists() && !file.mkdirs())" because mkdirs returns false if the folder already exists.
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang reassigned KARAF-643:
----------------------------------
Assignee: Freeman Fang
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Freeman Fang
> Priority: Trivial
> Fix For: 3.0.1, 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré reassigned KARAF-643:
------------------------------------------
Assignee: Jean-Baptiste Onofré
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: runtime
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-643:
---------------------------------
Fix Version/s: 3.0.1
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 3.0.1, 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-643) KarArtifactInstaller::init has
incorrect warning logic
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432870#comment-13432870 ]
Freeman Fang commented on KARAF-643:
------------------------------------
Hi,
Yeah, we should take Chris's approach here.
Freeman
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
> Key: KARAF-643
> URL: https://issues.apache.org/jira/browse/KARAF-643
> Project: Karaf
> Issue Type: Bug
> Components: karaf-kar
> Affects Versions: 2.2.0, 2.2.1
> Environment: Ubuntu Linux (though I believe the issue affects all platforms).
> Reporter: Yaytay
> Assignee: Freeman Fang
> Priority: Trivial
> Fix For: 3.0.1, 3.1.0
>
> Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
> logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira