You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/18 00:05:44 UTC

[GitHub] [spark] mridulm commented on pull request #31556: [SPARK-34431][CORE] Only load `hive-site.xml` once

mridulm commented on pull request #31556:
URL: https://github.com/apache/spark/pull/31556#issuecomment-780936554


   
   Wont this not cause issues at executor with user provided hive-site.xml (and use of ChildFirstURLClassLoader)  if platform has a conflicting hive-site in classpath ?
   Executor will force load of platform hive-site as part of its initialization (via `SparkHadoopUtil` use/initialization) - while things like TableReader will now depend on config populated with platform hive-site and not user overridden hive-site.
   
   (Was looking at merged PR's, so if I am missing something, please let me know.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org