You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by my...@apache.org on 2019/03/22 07:27:18 UTC

[fineract] branch develop updated: Remove requirement for single commit

This is an automated email from the ASF dual-hosted git repository.

myrle pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new b70e540  Remove requirement for single commit
b70e540 is described below

commit b70e540ec649aaf80cd923e721ef871d0e2a0e8d
Author: Myrle Krantz <my...@apache.org>
AuthorDate: Fri Mar 22 08:27:10 2019 +0100

    Remove requirement for single commit
    
    Based on discussion here:
     https://lists.apache.org/thread.html/0cd7baec95e7b2b937aeec8c39afd6eb78d36708cb848a26e7b397af@%3Cdev.fineract.apache.org%3E
    
    Removed requirement for single commit contributions in order to make development process easier to understand and participate in.
---
 .github/PULL_REQUEST_TEMPLATE.MD | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.MD b/.github/PULL_REQUEST_TEMPLATE.MD
index 586f5f7..7ba444e 100644
--- a/.github/PULL_REQUEST_TEMPLATE.MD
+++ b/.github/PULL_REQUEST_TEMPLATE.MD
@@ -12,8 +12,8 @@ Please make sure these boxes are checked before submitting your pull request - t
 
 - [ ] Integration tests have been created/updated for verifying the changes made.
 
-- [ ] All Integrations tests are passing with the new commit.
+- [ ] All Integrations tests are passing with the new commits.
 
-- [ ] PR contains a single commit (If you have multiple commits, please squash them into a single commit).
+- [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
 
 Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide