You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/31 18:30:28 UTC

[GitHub] [spark] huaxingao commented on issue #26344: [SPARK-29686][ML] LinearSVC should persist instances if needed

huaxingao commented on issue #26344: [SPARK-29686][ML] LinearSVC should persist instances if needed
URL: https://github.com/apache/spark/pull/26344#issuecomment-548510267
 
 
   One general question: what is the criteria to add the persistence support? I took a quick look of the ml code, seems some of them have the persistence support, some of them don't. For example, in classification, ```LogisticRegression```, ```OneVsRest``` and this ```LinearSVC``` have persistence support, but others don't. I didn't quite figure out when we need to persist the data. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org