You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/15 21:35:33 UTC
Review Request 55549: Windows: Added health checker to build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55549/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Bugs: MESOS-6709
https://issues.apache.org/jira/browse/MESOS-6709
Repository: mesos
Description
-------
This is a blocker for MESOS-6709, which requires both the health checker
and the TCP connector to build and work on Windows.
Diffs
-----
src/health-check/CMakeLists.txt ce195e2820c70dd7ebec1f06a6382f58fc729af7
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
src/health-check/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9
Diff: https://reviews.apache.org/r/55549/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55549: Windows: Added health checker to build.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Jan. 24, 2017, 9:37 p.m., Joseph Wu wrote:
> > src/health-check/tcp_connect.cpp, lines 33-38
> > <https://reviews.apache.org/r/55549/diff/1/?file=1605582#file1605582line33>
> >
> > Libprocess headers should go above stout headers.
Oh, did this change recently, or have I just always done this wrong?
> On Jan. 24, 2017, 9:37 p.m., Joseph Wu wrote:
> > src/health-check/tcp_connect.cpp, lines 148-150
> > <https://reviews.apache.org/r/55549/diff/1/?file=1605582#file1605582line148>
> >
> > Should there be a `process::finalize` here?
Actually, now that I think about it, this should not take a dependency on libprocess at all. Let's use the Stout WSA functions instead.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55549/#review162853
-----------------------------------------------------------
On Jan. 15, 2017, 9:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55549/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2017, 9:35 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a blocker for MESOS-6709, which requires both the health checker
> and the TCP connector to build and work on Windows.
>
>
> Diffs
> -----
>
> src/health-check/CMakeLists.txt ce195e2820c70dd7ebec1f06a6382f58fc729af7
> src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
> src/health-check/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9
>
> Diff: https://reviews.apache.org/r/55549/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55549: Windows: Added health checker to build.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Jan. 24, 2017, 1:37 p.m., Joseph Wu wrote:
> > src/health-check/tcp_connect.cpp, lines 33-38
> > <https://reviews.apache.org/r/55549/diff/1/?file=1605582#file1605582line33>
> >
> > Libprocess headers should go above stout headers.
>
> Alex Clemmer wrote:
> Oh, did this change recently, or have I just always done this wrong?
You've gotten this right in the past. But it's easy to forget.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55549/#review162853
-----------------------------------------------------------
On Jan. 26, 2017, 12:45 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55549/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 12:45 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a blocker for MESOS-6709, which requires both the health checker
> and the TCP connector to build and work on Windows.
>
>
> Diffs
> -----
>
> src/checks/CMakeLists.txt ce195e2820c70dd7ebec1f06a6382f58fc729af7
> src/checks/health_checker.cpp e70bd7936752613a4f92c70c4c61cd7cdf7c4ee5
> src/checks/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9
>
> Diff: https://reviews.apache.org/r/55549/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55549: Windows: Added health checker to build.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55549/#review162853
-----------------------------------------------------------
src/health-check/CMakeLists.txt
<https://reviews.apache.org/r/55549/#comment234217>
Note: This file was moved to the `src/checks` folder. Same with the other files in this diff.
src/health-check/tcp_connect.cpp (lines 33 - 38)
<https://reviews.apache.org/r/55549/#comment234215>
Libprocess headers should go above stout headers.
src/health-check/tcp_connect.cpp (lines 148 - 150)
<https://reviews.apache.org/r/55549/#comment234216>
Should there be a `process::finalize` here?
- Joseph Wu
On Jan. 15, 2017, 1:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55549/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2017, 1:35 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a blocker for MESOS-6709, which requires both the health checker
> and the TCP connector to build and work on Windows.
>
>
> Diffs
> -----
>
> src/health-check/CMakeLists.txt ce195e2820c70dd7ebec1f06a6382f58fc729af7
> src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
> src/health-check/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9
>
> Diff: https://reviews.apache.org/r/55549/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55549: Windows: Added health checker to build.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55549/#review163171
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Jan. 26, 2017, 12:45 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55549/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 12:45 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6709
> https://issues.apache.org/jira/browse/MESOS-6709
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a blocker for MESOS-6709, which requires both the health checker
> and the TCP connector to build and work on Windows.
>
>
> Diffs
> -----
>
> src/checks/CMakeLists.txt ce195e2820c70dd7ebec1f06a6382f58fc729af7
> src/checks/health_checker.cpp e70bd7936752613a4f92c70c4c61cd7cdf7c4ee5
> src/checks/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9
>
> Diff: https://reviews.apache.org/r/55549/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55549: Windows: Added health checker to build.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55549/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 8:45 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Changes
-------
Address Joseph's comments.
Bugs: MESOS-6709
https://issues.apache.org/jira/browse/MESOS-6709
Repository: mesos
Description
-------
This is a blocker for MESOS-6709, which requires both the health checker
and the TCP connector to build and work on Windows.
Diffs (updated)
-----
src/checks/CMakeLists.txt ce195e2820c70dd7ebec1f06a6382f58fc729af7
src/checks/health_checker.cpp e70bd7936752613a4f92c70c4c61cd7cdf7c4ee5
src/checks/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9
Diff: https://reviews.apache.org/r/55549/diff/
Testing
-------
Thanks,
Alex Clemmer