[GitHub] [lucene-solr] dweiss edited a comment on issue #1070: LUCENE-9089: FST Builder fluent-style constructor.

[GitBox <gi...@apache.org>]

dweiss edited a comment on issue #1070: LUCENE-9089: FST Builder fluent-style constructor.
URL: https://github.com/apache/lucene-solr/pull/1070#issuecomment-564456551
 
 
   Right... I've always wondered how we should handle such things gracefully (and I'm a user of those "secret" APIs myself so a rename affects me too).
   
   On the other hand if we tangle ourselves with all sorts of deprecations of these experimental APIs then things will build up cruft like the current FST class which is quite horrible (and I'm saying this as a person who is responsible for the current state).
   
   I'd say go ahead and rename on master. My suggestion is not anything you have to hold on to: use your gut feeling to clean up in any way you like.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org