You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Anthony Vito (JIRA)" <ji...@codehaus.org> on 2007/02/07 23:49:44 UTC
[jira] Created: (MPLICENSE-3) JavaFileType does not work reliably
(yet)
JavaFileType does not work reliably (yet)
-----------------------------------------
Key: MPLICENSE-3
URL: http://jira.codehaus.org/browse/MPLICENSE-3
Project: maven-license-plugin
Issue Type: Bug
Reporter: Anthony Vito
Attachments: maven-license-plugin_vito_patch.diff
The summary was taken from Joakim Erdfelt svn log message of commit 465447. I have created an issue around it because I have a patch and the progress should be tracked.
The patch adds a micro parser to detect the location of Java comments as well as an object to query comment locations. This allows for the failing unit tests to pass, as well as some more difficult unit tests that I created to assure correctness.
I did not use JavaCC as the parser. Perhaps this is an exercise for the future. With the patch the plugin performs nicely for my needs, and I hope my work can help others.
The patch is against revision 503477 the last change for the directory as of today.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSANDBOX-1) JavaFileType does not work reliably
(yet)
Posted by "Anthony Vito (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSANDBOX-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Vito updated MSANDBOX-1:
--------------------------------
Attachment: maven-license-plugin_vito_patchv3.diff
OK, scape those, they barely work, and I forget to "add" the new files so they would be included in the svn diff. This patch fixes all the issues I could find with java files, and adds an option to be able to inject the license above the package statement rather then below it. This is where I like the license, so I added it as an option. More tests added also.
> JavaFileType does not work reliably (yet)
> -----------------------------------------
>
> Key: MSANDBOX-1
> URL: http://jira.codehaus.org/browse/MSANDBOX-1
> Project: Maven 2.x Sandbox
> Issue Type: Bug
> Reporter: Anthony Vito
> Attachments: maven-license-plugin_vito_patch.diff, maven-license-plugin_vito_patchv2.diff, maven-license-plugin_vito_patchv3.diff
>
>
> The summary was taken from Joakim Erdfelt svn log message of commit 465447. I have created an issue around it because I have a patch and the progress should be tracked.
> The patch adds a micro parser to detect the location of Java comments as well as an object to query comment locations. This allows for the failing unit tests to pass, as well as some more difficult unit tests that I created to assure correctness.
> I did not use JavaCC as the parser. Perhaps this is an exercise for the future. With the patch the plugin performs nicely for my needs, and I hope my work can help others.
> The patch is against revision 503477 the last change for the directory as of today.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSANDBOX-1) JavaFileType does not work reliably
(yet)
Posted by "Anthony Vito (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSANDBOX-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Vito updated MSANDBOX-1:
--------------------------------
Attachment: maven-license-plugin_vito_patchv2.diff
Update of patch. The regex for the import line was incorrect and didn't account for "*" usage. Also added is a test for the star usage.
> JavaFileType does not work reliably (yet)
> -----------------------------------------
>
> Key: MSANDBOX-1
> URL: http://jira.codehaus.org/browse/MSANDBOX-1
> Project: Maven 2.x Sandbox
> Issue Type: Bug
> Reporter: Anthony Vito
> Attachments: maven-license-plugin_vito_patch.diff, maven-license-plugin_vito_patchv2.diff
>
>
> The summary was taken from Joakim Erdfelt svn log message of commit 465447. I have created an issue around it because I have a patch and the progress should be tracked.
> The patch adds a micro parser to detect the location of Java comments as well as an object to query comment locations. This allows for the failing unit tests to pass, as well as some more difficult unit tests that I created to assure correctness.
> I did not use JavaCC as the parser. Perhaps this is an exercise for the future. With the patch the plugin performs nicely for my needs, and I hope my work can help others.
> The patch is against revision 503477 the last change for the directory as of today.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Moved: (MSANDBOX-1) JavaFileType does not work reliably
(yet)
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSANDBOX-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukas Theussl moved MPLICENSE-3 to MSANDBOX-1:
----------------------------------------------
Workflow: Maven New (was: jira)
Key: MSANDBOX-1 (was: MPLICENSE-3)
Project: Maven 2.x Sandbox (was: maven-license-plugin)
> JavaFileType does not work reliably (yet)
> -----------------------------------------
>
> Key: MSANDBOX-1
> URL: http://jira.codehaus.org/browse/MSANDBOX-1
> Project: Maven 2.x Sandbox
> Issue Type: Bug
> Reporter: Anthony Vito
> Attachments: maven-license-plugin_vito_patch.diff
>
>
> The summary was taken from Joakim Erdfelt svn log message of commit 465447. I have created an issue around it because I have a patch and the progress should be tracked.
> The patch adds a micro parser to detect the location of Java comments as well as an object to query comment locations. This allows for the failing unit tests to pass, as well as some more difficult unit tests that I created to assure correctness.
> I did not use JavaCC as the parser. Perhaps this is an exercise for the future. With the patch the plugin performs nicely for my needs, and I hope my work can help others.
> The patch is against revision 503477 the last change for the directory as of today.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira