[GitHub] [beam] robertwb commented on a change in pull request #12883: [BEAM-7746] Add more typing to metrics

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #12883:
URL: https://github.com/apache/beam/pull/12883#discussion_r498569928



##########
File path: sdks/python/apache_beam/metrics/metric.py
##########
@@ -101,23 +121,26 @@ def gauge(namespace, name):
   class DelegatingCounter(Counter):
     """Metrics Counter that Delegates functionality to MetricsEnvironment."""
     def __init__(self, metric_name):
+      # type: (MetricName) -> None
       super(Metrics.DelegatingCounter, self).__init__()
       self.metric_name = metric_name
-      self.inc = MetricUpdater(cells.CounterCell, metric_name, default=1)
+      self.inc = MetricUpdater(cells.CounterCell, metric_name, default=1)  # type: ignore[assignment]

Review comment:
       Yes, please go ahead and ignore this error. (Note also that this code is structured in this way for performance reasons; previously we had pipelines where the bulk of the CPU was spent in generic counter update code, whereas here MetricUpdater is as fast as possible for incrementing an int).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org