[jira] [Updated] (BIGTOP-1342) Make TestCLI usable for both HDFS and HCFS

["Martin Bukatovic (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BIGTOP-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Bukatovic updated BIGTOP-1342:
-------------------------------------

    Attachment: BIGTOP-1342.2.patch

Ok, attaching new patch {{BIGTOP-1342.2.patch}} with the following changes:
 * Removed {{bigtop-tests/test-artifacts/hadoop/src/main/resources/clitest_data/testHDFSConf.pristine.xml}} file (the original xml file, stored just for reference, not directly used from the code)
 * Fixed whitespace warnings: removed trailing whitespace with sed and rebased (via squash) the result with the first patch
{noformat}
sed -i 's/[\t\ ]*$//' testHDFSConf.xml
{noformat}
This means that if you compare 2nd path with the first one, you will see lot of whitespace changes.
 * Updated commit message.

So I'm declaring this path final, but before commiting into master, please recheck that updating maven pom files is not needed (I think that it should not be necessary, but I would not call myself a maven expert).

> Make TestCLI usable for both HDFS and HCFS
> ------------------------------------------
>
>                 Key: BIGTOP-1342
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1342
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 0.8.0
>            Reporter: Martin Bukatovic
>         Attachments: BIGTOP-1342.1.patch, BIGTOP-1342.2.patch
>
>
> Current TestCLI test cases are currently only runnable on HDFS.  Since the most
> test cases are applicable on any hadoop filesystem, it makes sense to
> make it general in hcfs sense.
> While most test cases are hcfs generic, some cases are only applicable to HDFS,
> so I propose split the current code into:
>  * general HCFS superclass (with most cases in {{testHCFSConf.xml}} file)
>  * HDFS specific subclass (with hdfs only cases in {{testHDFSConf.xml}})
> I would like to keep {{testHCFSConf.xml}} as a common base for any hadoop
> filesystem, which would require introduction of several additional variables to
> catch minor differences between GlusterFS and HDFS. This should be good enough
> for other hcfs implementations as well, but I didn't tested it.
> Before proposing patch for this, it make sense to have the following resolved:
>  * BIGTOP-1341 TestCLI cleanup
>  * BIGTOP-1334 Add DFS support to TestCLI



--
This message was sent by Atlassian JIRA
(v6.2#6252)