You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2009/10/27 14:13:46 UTC

svn commit: r830159 - in /httpd/mod_fcgid/trunk/modules/fcgid: fcgid_proctbl.h fcgid_proctbl_unix.c fcgid_proctbl_win.c

Author: trawick
Date: Tue Oct 27 13:13:45 2009
New Revision: 830159

URL: http://svn.apache.org/viewvc?rev=830159&view=rev
Log:
proctable_lock_table() and proctable_unlock_table() are only used in the file where
they're implemented; make static, axe module-public prototype, rename

Modified:
    httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl.h
    httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_unix.c
    httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_win.c

Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl.h
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl.h?rev=830159&r1=830158&r2=830159&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl.h (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl.h Tue Oct 27 13:13:45 2009
@@ -77,9 +77,6 @@
 apr_status_t proctable_post_config(server_rec * main_server,
                                    apr_pool_t * pconf);
 
-apr_status_t proctable_lock_table(void);
-apr_status_t proctable_unlock_table(void);
-
 fcgid_procnode *proctable_get_free_list(void);
 fcgid_procnode *proctable_get_busy_list(void);
 fcgid_procnode *proctable_get_idle_list(void);

Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_unix.c
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_unix.c?rev=830159&r1=830158&r2=830159&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_unix.c (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_unix.c Tue Oct 27 13:13:45 2009
@@ -200,12 +200,12 @@
     return rv;
 }
 
-apr_status_t proctable_lock_table(void)
+static apr_status_t proctable_lock_internal(void)
 {
     return apr_global_mutex_lock(g_sharelock);
 }
 
-apr_status_t proctable_unlock_table(void)
+static apr_status_t proctable_unlock_internal(void)
 {
     return apr_global_mutex_unlock(g_sharelock);
 }
@@ -258,7 +258,7 @@
     }
 
     /* Lock error is a fatal error */
-    if ((rv = proctable_lock_table()) != APR_SUCCESS) {
+    if ((rv = proctable_lock_internal()) != APR_SUCCESS) {
         ap_log_error(APLOG_MARK, APLOG_EMERG, rv, s,
                      "mod_fcgid: can't get lock in pid %" APR_PID_T_FMT,
                      getpid());
@@ -271,7 +271,7 @@
     /* Lock error is a fatal error */
     apr_status_t rv;
 
-    if ((rv = proctable_unlock_table()) != APR_SUCCESS) {
+    if ((rv = proctable_unlock_internal()) != APR_SUCCESS) {
         ap_log_error(APLOG_MARK, APLOG_EMERG, rv, s,
                      "mod_fcgid: can't unlock in pid %" APR_PID_T_FMT, 
                      getpid());

Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_win.c
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_win.c?rev=830159&r1=830158&r2=830159&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_win.c (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_proctbl_win.c Tue Oct 27 13:13:45 2009
@@ -76,12 +76,12 @@
     return APR_SUCCESS;
 }
 
-apr_status_t proctable_lock_table()
+static apr_status_t proctable_lock_internal()
 {
     return apr_thread_mutex_lock(g_sharelock);
 }
 
-apr_status_t proctable_unlock_table()
+static apr_status_t proctable_unlock_internal()
 {
     return apr_thread_mutex_unlock(g_sharelock);
 }
@@ -126,7 +126,7 @@
     /* Lock error is a fatal error */
     apr_status_t rv;
 
-    if ((rv = proctable_lock_table()) != APR_SUCCESS) {
+    if ((rv = proctable_lock_internal()) != APR_SUCCESS) {
         ap_log_error(APLOG_MARK, APLOG_EMERG, rv, s,
                      "mod_fcgid: can't get lock");
         exit(1);
@@ -138,7 +138,7 @@
     /* Lock error is a fatal error */
     apr_status_t rv;
 
-    if ((rv = proctable_unlock_table()) != APR_SUCCESS) {
+    if ((rv = proctable_unlock_internal()) != APR_SUCCESS) {
         ap_log_error(APLOG_MARK, APLOG_EMERG, rv, s,
                      "mod_fcgid: can't unlock");
         exit(1);