You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/03 05:18:37 UTC
[GitHub] [ozone] kaijchen opened a new pull request, #3378: HDDS-6689. New checkstyle: NoLineWrap
kaijchen opened a new pull request, #3378:
URL: https://github.com/apache/ozone/pull/3378
## What changes were proposed in this pull request?
Add new checkstyle rule `NoLineWrap`, which checks no line wrap in `pacakge`, `import` and `static import` statements.
https://checkstyle.sourceforge.io/config_whitespace.html#NoLineWrap
Fix violations by running the following command multiple times.
```shell
grep -rlE '^import [^;]*$' --include '*.java' | xargs sed -szi 's/\(\nimport [^;\n]\+\)\n \+/\1/g'
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6689
## How was this patch tested?
Existing CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3378: HDDS-6689. New checkstyle: NoLineWrap
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3378:
URL: https://github.com/apache/ozone/pull/3378#issuecomment-1137381589
Thanks @adoroszlai for the comments. Actually I'm closing this for the same reason.
This patch is very easy to make (by command), and we can wait for a good chance to reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3378: HDDS-6689. New checkstyle: NoLineWrap
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3378:
URL: https://github.com/apache/ozone/pull/3378#issuecomment-1137362833
Thanks @kaijchen for the patch. I think it's a nice improvement. However, there are a few feature branches out there, some planned to be merged soon. I would like to avoid causing conflicts or failures for them due to this change. So let's re-visit this once those branches are merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen closed pull request #3378: HDDS-6689. New checkstyle: NoLineWrap
Posted by GitBox <gi...@apache.org>.
kaijchen closed pull request #3378: HDDS-6689. New checkstyle: NoLineWrap
URL: https://github.com/apache/ozone/pull/3378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen closed pull request #3378: HDDS-6689. New checkstyle: NoLineWrap
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen closed pull request #3378: HDDS-6689. New checkstyle: NoLineWrap
URL: https://github.com/apache/ozone/pull/3378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org