[GitHub] [beam] kennknowles opened a new issue, #19262: [GoSDK] There should be a combineFn unit tester that validates lifting.

[GitBox <gi...@apache.org>]

kennknowles opened a new issue, #19262:
URL: https://github.com/apache/beam/issues/19262

   The Go direct runner doesn't handle combiner lifting, which means combiners aren't validated whether they support lifting correctly or not. It should be possible for the ptest package to simulate combiner lifting, and actuate the lifecycle methods, or for the direct runner to be re-written to handle combiner lifting as a configuration option. This would make it easier to avoid mistakes and typos when handling lifecycle methods for CombineFns.
   
    
   
   In particular look at [https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/transforms/top/top_test.go](https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/transforms/top/top_test.go) which could be much simpler for users implementing combiners and avoid the manual scaffolding.
   
   Imported from Jira [BEAM-6682](https://issues.apache.org/jira/browse/BEAM-6682). Original Jira may contain additional context.
   Reported by: lostluck.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org