You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/10/14 19:10:29 UTC

Re: Review Request 21277: Passed CommandInfo to mesos-fetcher as JSON.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21277/#review56549
-----------------------------------------------------------


LGTM but needs rebase. Would be sweet to get in: much more robust than magic encoding :-)

- Niklas Nielsen


On May 9, 2014, 12:05 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21277/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 12:05 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Tom Arnfeld.
> 
> 
> Bugs: MESOS-1248
>     https://issues.apache.org/jira/browse/MESOS-1248
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary (and bug).
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 
>   src/slave/fetcher.hpp PRE-CREATION 
>   src/tests/fetcher_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21277/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 21277: Passed CommandInfo to mesos-fetcher as JSON.

Posted by Bernd Mathiske <be...@mesosphere.io>.


> On Oct. 14, 2014, 10:10 a.m., Niklas Nielsen wrote:
> > LGTM but needs rebase. Would be sweet to get in: much more robust than magic encoding :-)
> 
> Bernd Mathiske wrote:
>     I will work on it.

I have a patch. It depends on https://reviews.apache.org/r/27516/, which has not been reviewed yet. Trying to figure out how I can post a dependent patch...


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21277/#review56549
-----------------------------------------------------------


On May 9, 2014, 12:05 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21277/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 12:05 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Tom Arnfeld.
> 
> 
> Bugs: MESOS-1248
>     https://issues.apache.org/jira/browse/MESOS-1248
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary (and bug).
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 
>   src/slave/fetcher.hpp PRE-CREATION 
>   src/tests/fetcher_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21277/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 21277: Passed CommandInfo to mesos-fetcher as JSON.

Posted by Bernd Mathiske <be...@mesosphere.io>.


> On Oct. 14, 2014, 10:10 a.m., Niklas Nielsen wrote:
> > LGTM but needs rebase. Would be sweet to get in: much more robust than magic encoding :-)

I will work on it.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21277/#review56549
-----------------------------------------------------------


On May 9, 2014, 12:05 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21277/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 12:05 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Tom Arnfeld.
> 
> 
> Bugs: MESOS-1248
>     https://issues.apache.org/jira/browse/MESOS-1248
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary (and bug).
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 
>   src/slave/fetcher.hpp PRE-CREATION 
>   src/tests/fetcher_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21277/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>