[GitHub] [airflow] uranusjr commented on a change in pull request #20434: Fix mypy tests/providers/amazon/aws/operators

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #20434:
URL: https://github.com/apache/airflow/pull/20434#discussion_r773553970



##########
File path: tests/providers/amazon/aws/operators/test_eks.py
##########
@@ -49,10 +52,41 @@
 NAME_LIST = ["foo", "bar", "baz", "qux"]
 
 
+class clusterParams(TypedDict):

Review comment:
       ```suggestion
   class ClusterParams(TypedDict):
   ```
   
   Conventionally types should use CamelCases. (Same for all others below.)

##########
File path: tests/providers/amazon/aws/operators/test_eks.py
##########
@@ -16,8 +16,11 @@
 # specific language governing permissions and limitations
 # under the License.
 import unittest
+from typing import Any, Dict, List, Optional
 from unittest import mock
 
+from typing_extensions import TypedDict

Review comment:
       ```suggestion
   from airflow.typing_compat import TypedDict
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org