You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/15 18:46:34 UTC

[GitHub] [hbase] wchevreuil commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

wchevreuil commented on pull request #2399:
URL: https://github.com/apache/hbase/pull/2399#issuecomment-692904135


   > Please create addendum first and then backport it to branch-2?
   
   Sure, addendum is created here: https://github.com/apache/hbase/pull/2400
   
   > And now, seems we will block in the startup method forever?
   
   Holy cow, you're right @Apache9 . That's not the original intention, we should not block startup here, I was so eager to fix the race condition issue and didn't notice the side effect.
   
   > I think a better solution is to do the retry in the initThread so we will not block the startup call? 
   
   Definitely, yeah. Let me do this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org