You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Zhihong Yu (JIRA)" <ji...@apache.org> on 2012/05/04 22:26:48 UTC
[jira] [Created] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Zhihong Yu created HBASE-5942:
---------------------------------
Summary: HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
Key: HBASE-5942
URL: https://issues.apache.org/jira/browse/HBASE-5942
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.1
Reporter: Zhihong Yu
HConnnectionManager.getRegionServerWithRetries:
{code}
return callable.call();
} catch (Throwable t) {
callable.shouldRetry(t);
{code}
shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270760#comment-13270760 ]
Zhihong Yu commented on HBASE-5942:
-----------------------------------
This issue is for 0.92 branch only.
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.2
>
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5942:
-------------------------
Assignee: ramkrishna.s.vasudevan
Status: Patch Available (was: Open)
lgtm
Trying against hadoopqa
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Assignee: ramkrishna.s.vasudevan
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270923#comment-13270923 ]
Hudson commented on HBASE-5942:
-------------------------------
Integrated in HBase-0.92 #402 (See [https://builds.apache.org/job/HBase-0.92/402/])
HBASE-5942 HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly (Revision 1335734)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.2
>
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278522#comment-13278522 ]
Hudson commented on HBASE-5942:
-------------------------------
Integrated in HBase-0.92-security #107 (See [https://builds.apache.org/job/HBase-0.92-security/107/])
HBASE-5942 HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly (Revision 1335734)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.2
>
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5942:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to 0.92 (thanks for pointer Ted). Thanks for patch Ram.
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.2
>
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270758#comment-13270758 ]
Hadoop QA commented on HBASE-5942:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525951/hbase-5942.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1800//console
This message is automatically generated.
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Assignee: ramkrishna.s.vasudevan
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5942:
------------------------------
Fix Version/s: 0.92.2
Hadoop Flags: Reviewed
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.2
>
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270187#comment-13270187 ]
ramkrishna.s.vasudevan edited comment on HBASE-5942 at 5/8/12 4:31 AM:
-----------------------------------------------------------------------
The above issue, Ted had pointed in one of my earlier patches which was a backporting issue. I dont remember the JIRA id now.
{edit}
Please review. Applies to 0.92.
{edit}
was (Author: ram_krish):
The above issue, Ted had pointed in one of my earlier patches which was a backporting issue. I dont remember the JIRA id now.
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5942:
------------------------------------------
Attachment: hbase-5942.patch
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5942)
HConnnectionManager.getRegionServerWithRetries doesn't call afterCall
properly
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270187#comment-13270187 ]
ramkrishna.s.vasudevan commented on HBASE-5942:
-----------------------------------------------
The above issue, Ted had pointed in one of my earlier patches which was a backporting issue. I dont remember the JIRA id now.
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
> Key: HBASE-5942
> URL: https://issues.apache.org/jira/browse/HBASE-5942
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: Zhihong Yu
> Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
> return callable.call();
> } catch (Throwable t) {
> callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira