You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/27 09:23:02 UTC
[GitHub] [spark] ulysses-you commented on issue #28049: [SPARK-31285][CORE]
Do not upper case schedule mode in TaskSchedulerImpl
ulysses-you commented on issue #28049: [SPARK-31285][CORE] Do not upper case schedule mode in TaskSchedulerImpl
URL: https://github.com/apache/spark/pull/28049#issuecomment-604899525
> I think we should uppercase every where instead of lowercase, which is not acceptable for `SchedulingMode`.
Yeah. It can be.
But if we use `SchedulingMode` at other place in future, we may forget upper it too. I think the most simple way is keeping the raw string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org