You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "justing-bq (via GitHub)" <gi...@apache.org> on 2026/02/13 18:56:05 UTC

[PR] Add separate release & debug workflows for MacOS ODBC [arrow]

justing-bq opened a new pull request, #49284:
URL: https://github.com/apache/arrow/pull/49284

   ### Rationale for this change
   Addresses https://github.com/apache/arrow/issues/49283
   
   ### What changes are included in this PR
   The ODBC MacOS workflows now have release and debug workflows.
   
   ### Are these changes tested?
   Yes.
   
   ### Are there any user-facing changes?
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "justing-bq (via GitHub)" <gi...@apache.org>.
justing-bq commented on PR #49284:
URL: https://github.com/apache/arrow/pull/49284#issuecomment-3898841562

   @lidavidm this PR is ready for review. Please take a look when you can.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #49284:
URL: https://github.com/apache/arrow/pull/49284#issuecomment-4001751345

   OK. Could you add an explanation why we want to add release build to the PR description or associated issue?
   
   Could you fix CI failures?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49284:
URL: https://github.com/apache/arrow/pull/49284#issuecomment-3898840634

   :warning: GitHub issue #49283 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #49284:
URL: https://github.com/apache/arrow/pull/49284#issuecomment-3988925040

   @kou, any concerns?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49284:
URL: https://github.com/apache/arrow/pull/49284


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49284:
URL: https://github.com/apache/arrow/pull/49284#issuecomment-3898835120

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49284:
URL: https://github.com/apache/arrow/pull/49284#discussion_r2876767404


##########
.github/workflows/cpp_extra.yml:
##########
@@ -349,12 +349,13 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - architecture: AMD64
-            macos-version: "15-intel"
-          - architecture: ARM64
-            macos-version: "14"
+          - { architecture: AMD64, macos-version: "15-intel", build_type: debug }
+          - { architecture: AMD64, macos-version: "15-intel", build_type: release }
+          - { architecture: ARM64, macos-version: "14", build_type: debug }
+          - { architecture: ARM64, macos-version: "14", build_type: release }
     env:
       ARROW_BUILD_TESTS: ON
+      ARROW_BUILD_TYPE: ${{ matrix.build_type }}

Review Comment:
   Could you use `build-type` not `build_type` like we did for `macos-version`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49284:
URL: https://github.com/apache/arrow/pull/49284#issuecomment-4010404979

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bbf337b83a57df8bbf1dec59603a1b0abdf18423.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/66000964298) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49284:
URL: https://github.com/apache/arrow/pull/49284#issuecomment-3999462620

   > Why do you need both of release and debug builds? May we have any problems only with release build?
   
   I don't think there will be issues if we just have release build. We were thinking that if both release and debug versions build on macOS in the CI, it would be good to test both for more coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49284:
URL: https://github.com/apache/arrow/pull/49284#issuecomment-4008058731

   @kou Yes of course. I have posted a comment https://github.com/apache/arrow/issues/49283#issuecomment-4006956469  since Justin is currently out of office and I don't have edit access to the issue or PR. 
   
   Thanks for catching the failure, I have fixed it in the workflows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49283: [C++][FlightRPC] Add separate release & debug workflows for MacOS ODBC [arrow]

Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #49284:
URL: https://github.com/apache/arrow/pull/49284#discussion_r2885426486


##########
.github/workflows/cpp_extra.yml:
##########
@@ -349,12 +349,13 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - architecture: AMD64
-            macos-version: "15-intel"
-          - architecture: ARM64
-            macos-version: "14"
+          - { architecture: AMD64, macos-version: "15-intel", build_type: debug }
+          - { architecture: AMD64, macos-version: "15-intel", build_type: release }
+          - { architecture: ARM64, macos-version: "14", build_type: debug }
+          - { architecture: ARM64, macos-version: "14", build_type: release }
     env:
       ARROW_BUILD_TESTS: ON
+      ARROW_BUILD_TYPE: ${{ matrix.build_type }}

Review Comment:
   Sure, fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org