[GitHub] [pulsar] murong00 commented on a change in pull request #4502: [Issue 4480] Support setting zk chroot path when initialize cluster metadata

[GitBox <gi...@apache.org>]

murong00 commented on a change in pull request #4502: [Issue 4480] Support setting zk chroot path when initialize cluster metadata
URL: https://github.com/apache/pulsar/pull/4502#discussion_r292305282
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
 ##########
 @@ -93,7 +92,7 @@
         private String globalZookeeper;
 
         @Parameter(names = { "-cs",
-            "--configuration-store" }, description = "Configuration Store connection string", required = false)
+            "--configuration-store" }, description = "Configuration Store connection string", required = true)
 
 Review comment:
   If someone missed this option, it will print error `Configuration store address argument is required (--configuration-store)` since `--global-zookeeper` option is hidden . So it may be better to make this option `required`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services