You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by gi...@git.apache.org on 2017/06/29 23:10:11 UTC

[GitHub] mkiiskila commented on issue #358: Adding Eclipse Paho MQTT C/C++ client for Embedded platforms

mkiiskila commented on issue #358: Adding Eclipse Paho MQTT C/C++ client for Embedded platforms
URL: https://github.com/apache/mynewt-core/pull/358#issuecomment-312132287
 
 
   Could you move the header files a little bit deeper?
   E.g. net/mqtt/eclipse/include/MQTTConnect.h should be named:
   net/mqtt/eclipse/include/mqtt/MQTTConnect.h
   
   This approach we took so that packages who want to include this would say:
   #include <mqtt/MQTTConnect.h>, making it clear the origin of that header file.
   
   Good that you have the eclipse distribution license with this package.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services