You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bb...@apache.org on 2018/03/28 14:49:56 UTC
mesos git commit: Fixed test to assert precondition.
Repository: mesos
Updated Branches:
refs/heads/master ab65fb3b6 -> f01615178
Fixed test to assert precondition.
This patch changes an assert in
`ResourceProviderManagerHttpApiTest.UpdateOperationStatus` to make
sure a received message has the correct type. We later assume a
certain type which would not only abort the test if an unexpected
message type is received but also lead to hard runtime failures like
segmentation faults.
Review: https://reviews.apache.org/r/66331/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f0161517
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f0161517
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f0161517
Branch: refs/heads/master
Commit: f01615178f23010f03f936d60383126750cb4f56
Parents: ab65fb3
Author: Benjamin Bannier <be...@mesosphere.io>
Authored: Wed Mar 28 16:46:34 2018 +0200
Committer: Benjamin Bannier <bb...@apache.org>
Committed: Wed Mar 28 16:46:34 2018 +0200
----------------------------------------------------------------------
src/tests/resource_provider_manager_tests.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/f0161517/src/tests/resource_provider_manager_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/resource_provider_manager_tests.cpp b/src/tests/resource_provider_manager_tests.cpp
index d947bd0..05ae5de 100644
--- a/src/tests/resource_provider_manager_tests.cpp
+++ b/src/tests/resource_provider_manager_tests.cpp
@@ -437,7 +437,7 @@ TEST_P(ResourceProviderManagerHttpApiTest, UpdateOperationStatus)
AWAIT_READY(message);
- EXPECT_EQ(
+ ASSERT_EQ(
ResourceProviderMessage::Type::UPDATE_OPERATION_STATUS,
message->type);
EXPECT_EQ(