[GitHub] [openwhisk-package-alarms] style95 commented on a change in pull request #208: Fixed strict option not working

[GitBox <gi...@apache.org>]

style95 commented on a change in pull request #208: Fixed strict option not working
URL: https://github.com/apache/openwhisk-package-alarms/pull/208#discussion_r388805099
 
 

 ##########
 File path: provider/lib/cronAlarm.js
 ##########
 @@ -104,7 +104,7 @@ module.exports = function(logger, newTrigger) {
         var method = "distributeCronAlarm";
 
         var cronFields = (trigger.cron + '').trim().split(/\s+/);
-        if (trigger.strict !== 'true' && cronFields.length === 5 && delayLimit !== 0) {
+        if (!trigger.strict && cronFields.length === 5 && delayLimit !== 0) {
 
 Review comment:
   If a `strict` parameter does not exist, it will add some delays by default.
   So an OW operator can choose whether to enable this feature by setting up `ALARM_DELAY_LIMIT`.
   
   I think the documentation should be updated as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services