You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/01/28 00:46:06 UTC
Review Request 17431: Enabled configuration of the mesos master from the UI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Diffs
-----
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32924
-----------------------------------------------------------
src/webui/master/static/config.html
<https://reviews.apache.org/r/17431/#comment61955>
Convention in modals is to put the primary action in the bottom right, I think these should be switched.
- Ross Allen
On Jan. 27, 2014, 11:56 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 11:56 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32921
-----------------------------------------------------------
src/webui/master/static/config.html
<https://reviews.apache.org/r/17431/#comment61953>
Also, it might be useful to set the current hostname as the `placeholder` so it doesn't look empty. It would be something like `placeholder="http://hostname.of.mesos:5050"
- Ross Allen
On Jan. 27, 2014, 11:56 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 11:56 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32922
-----------------------------------------------------------
src/webui/master/static/index.html
<https://reviews.apache.org/r/17431/#comment61954>
Anchors don't get the pointer cursor unless they have an `href` attribute. This might be better as a button anyway since it's not nav, something like
<button type="button" class="btn btn-link" ng-click>
<i class="glyphicon glyphicon-cog"></i>
</button>
- Ross Allen
On Jan. 27, 2014, 11:56 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 11:56 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32919
-----------------------------------------------------------
src/webui/master/static/config.html
<https://reviews.apache.org/r/17431/#comment61949>
Add a `class="modal-title"` here to remove the bottom/top margin from the heading.
That comes from core Bootstrap: http://getbootstrap.com/javascript/#modals
src/webui/master/static/config.html
<https://reviews.apache.org/r/17431/#comment61950>
Can this describe the format? Maybe "Master URL"
src/webui/master/static/config.html
<https://reviews.apache.org/r/17431/#comment61951>
Needs an ID matching the `for` attribute of the associated <label>:
id="masterHost"
- Ross Allen
On Jan. 27, 2014, 11:56 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 11:56 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32932
-----------------------------------------------------------
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/17431/#comment61960>
This should use the $location service instead of the global window.location.
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/17431/#comment61961>
Use the Angular $location API if possible instead of the global window.location: http://docs.angularjs.org/api/ng.$location
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/17431/#comment61962>
$location service here too instead of a global.
- Ross Allen
On Jan. 28, 2014, 12:53 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 12:53 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32931
-----------------------------------------------------------
src/webui/master/static/index.html
<https://reviews.apache.org/r/17431/#comment61958>
`location.origin` is copied in a couple places. This should work for now, but we should figure out a more robust config setup for defaults, etc.
- Ross Allen
On Jan. 28, 2014, 12:53 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 12:53 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32935
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/17431/#comment61972>
Oh hey, this should be "config.html" not "config/html" right?
- Ross Allen
On Jan. 28, 2014, 1:44 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 1:44 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 29, 2014, 8:34 p.m., Ross Allen wrote:
> > src/webui/master/static/js/controllers.js, line 342
> > <https://reviews.apache.org/r/17431/diff/11/?file=453077#file453077line342>
> >
> > Nuke the console.log for production use.
I need a pre-commit lint hook for console.log.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review33160
-----------------------------------------------------------
On Jan. 28, 2014, 8:51 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 8:51 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review33160
-----------------------------------------------------------
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/17431/#comment62464>
Nuke the console.log for production use.
- Ross Allen
On Jan. 28, 2014, 8:51 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 8:51 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56536
-----------------------------------------------------------
Bad patch!
Reviews applied: [17431]
Failed command: git apply --index 17431.patch
Error:
error: patch failed: CHANGELOG:1
error: CHANGELOG: patch does not apply
error: patch failed: configure.ac:18
error: configure.ac: patch does not apply
error: patch failed: docs/upgrades.md:5
error: docs/upgrades.md: patch does not apply
error: patch failed: src/log/catchup.cpp:207
error: src/log/catchup.cpp: patch does not apply
error: patch failed: src/master/http.cpp:325
error: src/master/http.cpp: patch does not apply
error: patch failed: src/slave/http.cpp:285
error: src/slave/http.cpp: patch does not apply
17431.patch:456: new blank line at EOF.
+
- Mesos ReviewBot
On Jan. 29, 2014, 8:51 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 8:51 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> CHANGELOG e75a3411f865cb7f3768df1299f469f49c3a0009
> bin/lldb-mesos-local.sh.in 35011fd483e477701efd7e204b514bb362713ccb
> bin/lldb-mesos-master.sh.in b1c7f9f1b98b5f410729f5a7e7a1729709f7e744
> bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955
> bin/lldb-mesos-tests.sh.in f001b0b7f35839a101a86cd7df86fb7ebfc1c47e
> configure.ac 18bf4bfb345bdd443defccc4e53d357b35c7b533
> docs/upgrades.md fe8b60470f7431accef44977e7036a2688289037
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/log/catchup.cpp 4ee32f285f77eb2de661e22a301b743bb8a06f9c
> src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c
> src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Oct. 14, 2014, 4:02 p.m., Niklas Nielsen wrote:
> > The latest diff looks broken - Thomas, mind updating it (if you still want this to go in)?
Why in the world didn't this get in. I'll fix it up =)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56533
-----------------------------------------------------------
On Jan. 29, 2014, 8:51 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 8:51 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> CHANGELOG e75a3411f865cb7f3768df1299f469f49c3a0009
> bin/lldb-mesos-local.sh.in 35011fd483e477701efd7e204b514bb362713ccb
> bin/lldb-mesos-master.sh.in b1c7f9f1b98b5f410729f5a7e7a1729709f7e744
> bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955
> bin/lldb-mesos-tests.sh.in f001b0b7f35839a101a86cd7df86fb7ebfc1c47e
> configure.ac 18bf4bfb345bdd443defccc4e53d357b35c7b533
> docs/upgrades.md fe8b60470f7431accef44977e7036a2688289037
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/log/catchup.cpp 4ee32f285f77eb2de661e22a301b743bb8a06f9c
> src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c
> src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56533
-----------------------------------------------------------
The latest diff looks broken - Thomas, mind updating it (if you still want this to go in)?
- Niklas Nielsen
On Jan. 29, 2014, 12:51 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 12:51 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> CHANGELOG e75a3411f865cb7f3768df1299f469f49c3a0009
> bin/lldb-mesos-local.sh.in 35011fd483e477701efd7e204b514bb362713ccb
> bin/lldb-mesos-master.sh.in b1c7f9f1b98b5f410729f5a7e7a1729709f7e744
> bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955
> bin/lldb-mesos-tests.sh.in f001b0b7f35839a101a86cd7df86fb7ebfc1c47e
> configure.ac 18bf4bfb345bdd443defccc4e53d357b35c7b533
> docs/upgrades.md fe8b60470f7431accef44977e7036a2688289037
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/log/catchup.cpp 4ee32f285f77eb2de661e22a301b743bb8a06f9c
> src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c
> src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56636
-----------------------------------------------------------
Patch looks great!
Reviews applied: [17431]
All tests passed.
- Mesos ReviewBot
On Oct. 14, 2014, 10:54 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 10:54 p.m.)
>
>
> Review request for mesos, Michael Lunøe and Niklas Nielsen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Michael Lunøe <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56926
-----------------------------------------------------------
I might want a loader, so the user knows that something is going on, or at least empty the current list.
src/webui/master/static/config.html
<https://reviews.apache.org/r/17431/#comment97367>
Maybe a convinience method? Took me a while to figure out what was going on.
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/17431/#comment97366>
`;` after return statement?
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/17431/#comment97365>
`;` after return statement?
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/17431/#comment97371>
`=== -1`?
Also it seems that you're doing something similar here to what you're doing in config.html:
`location.absUrl().split('/').slice(0,3).join('/')`
I think puttings these into convenience methods somewhere would be good.
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/17431/#comment97363>
`if (config.host === '')`?
I didn't get too much into overall linting errors that are not in your code, but there are some errors that could correct. However, I'm not sure that's a task for this patch.
- Michael Lunøe
On Oct. 14, 2014, 10:54 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 10:54 p.m.)
>
>
> Review request for mesos, Michael Lunøe and Niklas Nielsen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Michael Lunøe <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56949
-----------------------------------------------------------
Ship it!
Looks good to me :)
- Michael Lunøe
On Oct. 16, 2014, 5:38 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 5:38 p.m.)
>
>
> Review request for mesos, Michael Lunøe and Niklas Nielsen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd1916373a7e525be967885bbd1a3a4aa0104
> configure.ac bb4fee4e7c7497336d61d5a47da3667a9bc14ee5
> src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
> src/master/main.cpp 29ded49f5c18b12dbe4ff9b69ee3343c04ce2cf8
> src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4
> src/slave/flags.hpp 159d4ef63643d17be353533992049a38aec72437
> src/slave/main.cpp b27cc32ebccb1c97f2f2ae0b904c725bbf541ebf
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Nov. 11, 2014, 7:28 p.m., Niklas Nielsen wrote:
> > Thomas, can you expand a bit on what is going on? It looks like you are doing more than just enabling the configuration of the master endpoint?
That's really it. To allow configuration of the master endpoint, a config dialog and directive was introduced. To make sure all configuration is part of that, the existing longDate toggle was moved into that namespace.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review60826
-----------------------------------------------------------
On Oct. 16, 2014, 6:41 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 6:41 p.m.)
>
>
> Review request for mesos, Michael Lunøe and Niklas Nielsen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review60826
-----------------------------------------------------------
Thomas, can you expand a bit on what is going on? It looks like you are doing more than just enabling the configuration of the master endpoint?
- Niklas Nielsen
On Oct. 16, 2014, 11:41 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 11:41 a.m.)
>
>
> Review request for mesos, Michael Lunøe and Niklas Nielsen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review56999
-----------------------------------------------------------
Patch looks great!
Reviews applied: [17431]
All tests passed.
- Mesos ReviewBot
On Oct. 16, 2014, 6:41 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 6:41 p.m.)
>
>
> Review request for mesos, Michael Lunøe and Niklas Nielsen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 6:41 p.m.)
Review request for mesos, Michael Lunøe and Niklas Nielsen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Connection Issue Alert
https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 5:38 p.m.)
Review request for mesos, Michael Lunøe and Niklas Nielsen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd1916373a7e525be967885bbd1a3a4aa0104
configure.ac bb4fee4e7c7497336d61d5a47da3667a9bc14ee5
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
src/master/main.cpp 29ded49f5c18b12dbe4ff9b69ee3343c04ce2cf8
src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4
src/slave/flags.hpp 159d4ef63643d17be353533992049a38aec72437
src/slave/main.cpp b27cc32ebccb1c97f2f2ae0b904c725bbf541ebf
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Connection Issue Alert
https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 10:54 p.m.)
Review request for mesos, Michael Lunøe and Niklas Nielsen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Connection Issue Alert
https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 10:53 p.m.)
Review request for mesos and Michael Lunøe.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Connection Issue Alert
https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master
from the UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 10:52 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Connection Issue Alert
https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 29, 2014, 8:51 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
CHANGELOG e75a3411f865cb7f3768df1299f469f49c3a0009
bin/lldb-mesos-local.sh.in 35011fd483e477701efd7e204b514bb362713ccb
bin/lldb-mesos-master.sh.in b1c7f9f1b98b5f410729f5a7e7a1729709f7e744
bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955
bin/lldb-mesos-tests.sh.in f001b0b7f35839a101a86cd7df86fb7ebfc1c47e
configure.ac 18bf4bfb345bdd443defccc4e53d357b35c7b533
docs/upgrades.md fe8b60470f7431accef44977e7036a2688289037
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/log/catchup.cpp 4ee32f285f77eb2de661e22a301b743bb8a06f9c
src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c
src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Connection Issue Alert
https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 29, 2014, 8:39 p.m., Ross Allen wrote:
> > src/webui/master/static/index.html, line 65
> > <https://reviews.apache.org/r/17431/diff/11/?file=453075#file453075line65>
> >
> > This can lead to an odd state, although it might be fine for now:
> >
> > 1. Open the config and set the host to something invalid like http://google.com
> > 2. The alert displays, says "Failed to connect to google.com ..."
> > 3. Click "set a new master" and delete the value, click "Save"
> >
> > After the modal closes, the alert now reads "Failed to connect to localhost:5050 ..." even though it hasn't tried to connect to it yet.
> >
> > Maybe the config modal could poll once on close if the master URL changed? This also might be too nuanced to be worth fixing.
It isn't optimal but I'd like to leave it this way for now. If it becomes a huge problem, we can fix it in the future.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review33161
-----------------------------------------------------------
On Jan. 28, 2014, 8:51 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 8:51 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review33161
-----------------------------------------------------------
src/webui/master/static/index.html
<https://reviews.apache.org/r/17431/#comment62465>
This can lead to an odd state, although it might be fine for now:
1. Open the config and set the host to something invalid like http://google.com
2. The alert displays, says "Failed to connect to google.com ..."
3. Click "set a new master" and delete the value, click "Save"
After the modal closes, the alert now reads "Failed to connect to localhost:5050 ..." even though it hasn't tried to connect to it yet.
Maybe the config modal could poll once on close if the master URL changed? This also might be too nuanced to be worth fixing.
- Ross Allen
On Jan. 28, 2014, 8:51 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 8:51 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
> Connection Issue Alert
> https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 8:51 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Connection Issue Alert
https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 8:46 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments (updated)
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Connection Issue Alert
https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 8:41 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 6:45 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 6:26 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 1:48 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 1:44 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 12:53 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
File Attachments (updated)
----------------
Config Dialog
https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 12:52 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
> On Jan. 28, 2014, 12:45 a.m., Ben Mahler wrote:
> > Screenshots? :)
> >
> > If we were to have a way to spin up the webui standalone, perhaps that's the only time we would want to expose this?
>
> Thomas Rampelberg wrote:
> I suspect that you're right. The impetus for the feature is having the UI be standalone at least.
>
> In general however, there's now a method for allowing local config (Ross' point about timestamps is a great one, I'll move those over). That doesn't mean that we couldn't hide the config menu however. At the moment, I'm treating this as a debug feature more than anything else. For a real standalone solution, I'd personally like to have something a little more usable.
This will anyone test UI changes on production clusters without updating Mesos on those clusters. You can run the UI locally and point to a real cluster. We are curious to see if the latest changes to pagination and filtering work on large clusters.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32927
-----------------------------------------------------------
On Jan. 28, 2014, 12:53 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 12:53 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 28, 2014, 12:45 a.m., Ben Mahler wrote:
> > Screenshots? :)
> >
> > If we were to have a way to spin up the webui standalone, perhaps that's the only time we would want to expose this?
I suspect that you're right. The impetus for the feature is having the UI be standalone at least.
In general however, there's now a method for allowing local config (Ross' point about timestamps is a great one, I'll move those over). That doesn't mean that we couldn't hide the config menu however. At the moment, I'm treating this as a debug feature more than anything else. For a real standalone solution, I'd personally like to have something a little more usable.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32927
-----------------------------------------------------------
On Jan. 28, 2014, 12:53 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 12:53 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Config Dialog
> https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32927
-----------------------------------------------------------
Screenshots? :)
If we were to have a way to spin up the webui standalone, perhaps that's the only time we would want to expose this?
- Ben Mahler
On Jan. 28, 2014, 12:34 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 12:34 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/#review32925
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/17431/#comment61956>
Can the timestamp config be moved into this object in local storage as well to use just one root key for user configuration?
- Ross Allen
On Jan. 28, 2014, 12:34 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17431/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 12:34 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-885
> https://issues.apache.org/jira/browse/mesos-885
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled configuration of the mesos master from the UI.
>
> Review: http://reviews.apache.org/r/17431
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/webui/master/static/config.html PRE-CREATION
> src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
> src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
>
> Diff: https://reviews.apache.org/r/17431/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 12:34 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 11:56 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 11:55 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-885
https://issues.apache.org/jira/browse/mesos-885
Repository: mesos-git
Description
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 11:50 p.m.)
Review request for mesos.
Repository: mesos-git
Description (updated)
-------
Enabled configuration of the mesos master from the UI.
Review: http://reviews.apache.org/r/17431
Diffs (updated)
-----
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the
UI.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 11:47 p.m.)
Review request for mesos.
Repository: mesos-git
Description (updated)
-------
Enabled configuration of the mesos master from the UI.
This solution is to help out with development and testing of the UI irrespective of Mesos' version.
Diffs
-----
src/webui/master/static/config.html PRE-CREATION
src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94
Diff: https://reviews.apache.org/r/17431/diff/
Testing
-------
Thanks,
Thomas Rampelberg