You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "lastbus (via GitHub)" <gi...@apache.org> on 2024/03/05 08:37:51 UTC

[PR] [SPARK-47279][CORE]When the messageLoop encounter a fatal exception, such as oom, exit the JVM to avoid the driver hanging forever [spark]

lastbus opened a new pull request, #45385:
URL: https://github.com/apache/spark/pull/45385

   
   ### What changes were proposed in this pull request?
   When a task has finished and sent messages back to the driver, but the driver cannot create new thread because of insufficient memory, then the driver will hangs indefinitely. In this situation, we choose to exit JVM.
   
   ### Why are the changes needed?
   Fatal exception may cause the driver hangs indefinitely.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   N/A
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47279][CORE]When the messageLoop encounter a fatal exception, such as oom, exit the JVM to avoid the driver hanging forever [spark]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #45385:
URL: https://github.com/apache/spark/pull/45385#issuecomment-1990595991

   Instead of handling such a special case here, JVM has provided helpful arguments to deal with OutOfMemoryError.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-47279][CORE]When the messageLoop encounter a fatal exception, such as oom, exit the JVM to avoid the driver hanging forever [spark]

Posted by "monkeyboy123 (via GitHub)" <gi...@apache.org>.
monkeyboy123 commented on PR #45385:
URL: https://github.com/apache/spark/pull/45385#issuecomment-1990909657

   > Instead of handling such a special case here, JVM has provided helpful arguments to deal with OutOfMemoryError.
   
   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org